From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AD391BC2A; Tue, 13 May 2025 00:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747096728; cv=none; b=EisaXC7un3aUdZ+bRg5Ympq6DmmTdo2CpQFn7gZc1bKsZPfboShp+dhwV4C92VJNU/4aRvae933vReTmNu5EcX7Ue5EbpzZqrLhkk7aWXBKZrWwRas9WY/a2vytt+C3nJFPSPHsnKUCQcqXhfX5pYv22eNVv5rpSFTXgcwFOP+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747096728; c=relaxed/simple; bh=flBB8DjvsauKMmFKOOZ3kglblEROS9qMRYYhOuXJGuk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hk/h1g5VGET1+jh7rshW10K8mNzeNXSou2FA8EkBDsm8yMGw0oHUDu1seX1jP1snRsOTvp2JCoRGNTH0w4vMTGMh2P3Hr93HmmKVvgEcCIGivX7F6APw9UjnpcG6XxKLzgxSfv8kcKzpv2u29kNJInDGZkpPFIcNI5dn9/vUUsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=msb6F8Id; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="msb6F8Id" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FA38C4CEE7; Tue, 13 May 2025 00:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747096728; bh=flBB8DjvsauKMmFKOOZ3kglblEROS9qMRYYhOuXJGuk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=msb6F8IdO+YfS7WclIgqjRBOasou2kc/kwcfHMFRQAxFgwjfnhRE4e/EhCimbMerm G2in5f3v0WIgcXRFAPvBV5/+gGaty9roH/IabkZHvgHlo0gz/aKFeQalc8K6Gkvmrc 3sWonqoSxSP+vb3TZoMFtgor7YdlNeeCIp+2YHt8y2fUTgUKugH3JUO2hjqvFTQbn1 7HD8pEIviDmSDf+h2scKBZwFiFwBmKSd1OTzmRioxxOYGy1IGgwTfj9r3qYvyPO05f 1d8k+fnxbzalVDjWSbnqm1Ms6op4GILNO37vutw3M/Atv+7BQ8gtLmswb1Rti7rtsW 41ZtD6hsGFfbw== Date: Mon, 12 May 2025 17:38:46 -0700 From: Jakub Kicinski To: Christophe JAILLET Cc: "Russell King (Oracle)" , Christian Marangi , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Paolo Abeni , Daniel Golle , Bartosz Golaszewski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [net PATCH] net: phy: aquantia: fix wrong GENMASK define for LED_PROV_ACT_STRETCH Message-ID: <20250512173846.511a2303@kernel.org> In-Reply-To: References: <20250511090619.3453606-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 11 May 2025 12:06:38 +0200 Christophe JAILLET wrote: > There is a compile time check, but in this case > VEND1_GLOBAL_LED_PROV_ACT_STRETCH looks unused. So it is never expanded > and compiled. Thanks! Given this the patch is obviously not a fix.