* [PATCH net-next] tools: ynl-gen: array-nest: support arrays of nests
@ 2025-05-13 22:20 Jakub Kicinski
2025-05-15 7:51 ` Donald Hunter
2025-05-15 22:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2025-05-13 22:20 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
donald.hunter, jacob.e.keller
TC needs arrays of nests, but just a put for now.
Fairly straightforward addition.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Sorry for trickling out random changes, I need
396786af1cea ("tools: ynl-gen: Allow multi-attr without nested-attributes again")
to reach net-next before I post submsg support. Otherwise there
will be a conflict.
CC: donald.hunter@gmail.com
CC: jacob.e.keller@intel.com
---
tools/net/ynl/pyynl/ynl_gen_c.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
index 3b064c61a374..cd150d704e28 100755
--- a/tools/net/ynl/pyynl/ynl_gen_c.py
+++ b/tools/net/ynl/pyynl/ynl_gen_c.py
@@ -825,6 +825,9 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S
elif self.sub_type == 'binary' and 'exact-len' in self.checks:
ri.cw.p(f'for (i = 0; i < {var}->_count.{self.c_name}; i++)')
ri.cw.p(f"ynl_attr_put(nlh, i, {var}->{self.c_name}[i], {self.checks['exact-len']});")
+ elif self.sub_type == 'nest':
+ ri.cw.p(f'for (i = 0; i < {var}->_count.{self.c_name}; i++)')
+ ri.cw.p(f"{self.nested_render_name}_put(nlh, i, &{var}->{self.c_name}[i]);")
else:
raise Exception(f"Put for ArrayNest sub-type {self.attr['sub-type']} not supported, yet")
ri.cw.p('ynl_attr_nest_end(nlh, array);')
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] tools: ynl-gen: array-nest: support arrays of nests
2025-05-13 22:20 [PATCH net-next] tools: ynl-gen: array-nest: support arrays of nests Jakub Kicinski
@ 2025-05-15 7:51 ` Donald Hunter
2025-05-15 22:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Donald Hunter @ 2025-05-15 7:51 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms,
jacob.e.keller
Jakub Kicinski <kuba@kernel.org> writes:
> TC needs arrays of nests, but just a put for now.
> Fairly straightforward addition.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] tools: ynl-gen: array-nest: support arrays of nests
2025-05-13 22:20 [PATCH net-next] tools: ynl-gen: array-nest: support arrays of nests Jakub Kicinski
2025-05-15 7:51 ` Donald Hunter
@ 2025-05-15 22:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-05-15 22:50 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms,
donald.hunter, jacob.e.keller
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 13 May 2025 15:20:11 -0700 you wrote:
> TC needs arrays of nests, but just a put for now.
> Fairly straightforward addition.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Sorry for trickling out random changes, I need
> 396786af1cea ("tools: ynl-gen: Allow multi-attr without nested-attributes again")
> to reach net-next before I post submsg support. Otherwise there
> will be a conflict.
>
> [...]
Here is the summary with links:
- [net-next] tools: ynl-gen: array-nest: support arrays of nests
https://git.kernel.org/netdev/net-next/c/87948df5af4b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-16 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-13 22:20 [PATCH net-next] tools: ynl-gen: array-nest: support arrays of nests Jakub Kicinski
2025-05-15 7:51 ` Donald Hunter
2025-05-15 22:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).