From: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Chwee-Lin Choong <chwee.lin.choong@intel.com>
Subject: [PATCH iwl-next v2 1/8] igc: move TXDCTL and RXDCTL related macros
Date: Wed, 14 May 2025 00:29:38 -0400 [thread overview]
Message-ID: <20250514042945.2685273-2-faizal.abdul.rahim@linux.intel.com> (raw)
In-Reply-To: <20250514042945.2685273-1-faizal.abdul.rahim@linux.intel.com>
Move and consolidate TXDCTL and RXDCTL macros in preparation for
upcoming TXDCTL changes. This improves organization and readability.
Signed-off-by: Faizal Rahim <faizal.abdul.rahim@linux.intel.com>
---
drivers/net/ethernet/intel/igc/igc.h | 11 ++++++++++-
drivers/net/ethernet/intel/igc/igc_base.h | 8 --------
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
index 859a15e4ccba..25695eada563 100644
--- a/drivers/net/ethernet/intel/igc/igc.h
+++ b/drivers/net/ethernet/intel/igc/igc.h
@@ -487,10 +487,19 @@ static inline u32 igc_rss_type(const union igc_adv_rx_desc *rx_desc)
*/
#define IGC_RX_PTHRESH 8
#define IGC_RX_HTHRESH 8
+#define IGC_RX_WTHRESH 4
+/* Ena specific Rx Queue */
+#define IGC_RXDCTL_QUEUE_ENABLE 0x02000000
+/* Receive Software Flush */
+#define IGC_RXDCTL_SWFLUSH 0x04000000
+
#define IGC_TX_PTHRESH 8
#define IGC_TX_HTHRESH 1
-#define IGC_RX_WTHRESH 4
#define IGC_TX_WTHRESH 16
+/* Ena specific Tx Queue */
+#define IGC_TXDCTL_QUEUE_ENABLE 0x02000000
+/* Transmit Software Flush */
+#define IGC_TXDCTL_SWFLUSH 0x04000000
#define IGC_RX_DMA_ATTR \
(DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING)
diff --git a/drivers/net/ethernet/intel/igc/igc_base.h b/drivers/net/ethernet/intel/igc/igc_base.h
index 6320eabb72fe..eaf17cd031c3 100644
--- a/drivers/net/ethernet/intel/igc/igc_base.h
+++ b/drivers/net/ethernet/intel/igc/igc_base.h
@@ -86,14 +86,6 @@ union igc_adv_rx_desc {
} wb; /* writeback */
};
-/* Additional Transmit Descriptor Control definitions */
-#define IGC_TXDCTL_QUEUE_ENABLE 0x02000000 /* Ena specific Tx Queue */
-#define IGC_TXDCTL_SWFLUSH 0x04000000 /* Transmit Software Flush */
-
-/* Additional Receive Descriptor Control definitions */
-#define IGC_RXDCTL_QUEUE_ENABLE 0x02000000 /* Ena specific Rx Queue */
-#define IGC_RXDCTL_SWFLUSH 0x04000000 /* Receive Software Flush */
-
/* SRRCTL bit definitions */
#define IGC_SRRCTL_BSIZEPKT_MASK GENMASK(6, 0)
#define IGC_SRRCTL_BSIZEPKT(x) FIELD_PREP(IGC_SRRCTL_BSIZEPKT_MASK, \
--
2.34.1
next prev parent reply other threads:[~2025-05-14 4:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 4:29 [PATCH iwl-next v2 0/8] igc: harmonize queue priority and add preemptible queue support Faizal Rahim
2025-05-14 4:29 ` Faizal Rahim [this message]
2025-05-16 9:44 ` [PATCH iwl-next v2 1/8] igc: move TXDCTL and RXDCTL related macros Simon Horman
2025-05-14 4:29 ` [PATCH iwl-next v2 2/8] igc: add DCTL prefix to " Faizal Rahim
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [PATCH iwl-next v2 3/8] igc: refactor TXDCTL macros to use FIELD_PREP and GEN_MASK Faizal Rahim
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [PATCH iwl-next v2 4/8] igc: assign highest TX queue number as highest priority in mqprio Faizal Rahim
2025-05-16 9:44 ` Simon Horman
2025-05-14 4:29 ` [PATCH iwl-next v2 5/8] igc: add private flag to reverse TX queue priority in TSN mode Faizal Rahim
2025-05-16 9:45 ` Simon Horman
2025-05-14 4:29 ` [PATCH iwl-next v2 6/8] igc: add preemptible queue support in taprio Faizal Rahim
2025-05-14 4:29 ` [PATCH iwl-next v2 7/8] igc: add preemptible queue support in mqprio Faizal Rahim
2025-05-14 4:29 ` [PATCH iwl-next v2 8/8] igc: SW pad preemptible frames for correct mCRC calculation Faizal Rahim
2025-05-16 9:43 ` Simon Horman
2025-05-19 6:27 ` Abdul Rahim, Faizal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514042945.2685273-2-faizal.abdul.rahim@linux.intel.com \
--to=faizal.abdul.rahim@linux.intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=chwee.lin.choong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).