* [PATCH] dt-bindings: net: snps,dwmac: Align mdio node in example with bindings
@ 2025-05-13 7:33 Geert Uytterhoeven
2025-05-14 12:48 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2025-05-13 7:33 UTC (permalink / raw)
To: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alexandre Torgue, Giuseppe Cavallaro, Jose Abreu
Cc: netdev, devicetree, linux-renesas-soc, Geert Uytterhoeven
According to the bindings, the MDIO subnode should be called "mdio".
Update the example to match this.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
For dwc-qos-ethernet-4.10, the Linux driver insists on "mdio".
For other devices, the Linux driver does not seem to care, and just
looks for subnodes that are compatible with "snps,dwmac-mdio":
https://elixir.bootlin.com/linux/v6.14.6/source/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c#L302
Lots of DTS files are using "mdio0" (copied from the example?).
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index b525eca5385067d8..90b79283e228b037 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -710,7 +710,7 @@ examples:
};
};
- mdio0 {
+ mdio {
#address-cells = <1>;
#size-cells = <0>;
compatible = "snps,dwmac-mdio";
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: net: snps,dwmac: Align mdio node in example with bindings
2025-05-13 7:33 [PATCH] dt-bindings: net: snps,dwmac: Align mdio node in example with bindings Geert Uytterhoeven
@ 2025-05-14 12:48 ` Simon Horman
2025-05-14 23:38 ` Rob Herring (Arm)
2025-05-15 2:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2025-05-14 12:48 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alexandre Torgue, Giuseppe Cavallaro, Jose Abreu, netdev,
devicetree, linux-renesas-soc
On Tue, May 13, 2025 at 09:33:56AM +0200, Geert Uytterhoeven wrote:
> According to the bindings, the MDIO subnode should be called "mdio".
> Update the example to match this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> For dwc-qos-ethernet-4.10, the Linux driver insists on "mdio".
> For other devices, the Linux driver does not seem to care, and just
> looks for subnodes that are compatible with "snps,dwmac-mdio":
> https://elixir.bootlin.com/linux/v6.14.6/source/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c#L302
>
> Lots of DTS files are using "mdio0" (copied from the example?).
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: snps,dwmac: Align mdio node in example with bindings
2025-05-13 7:33 [PATCH] dt-bindings: net: snps,dwmac: Align mdio node in example with bindings Geert Uytterhoeven
2025-05-14 12:48 ` Simon Horman
@ 2025-05-14 23:38 ` Rob Herring (Arm)
2025-05-15 2:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-05-14 23:38 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Paolo Abeni, David S . Miller, Jakub Kicinski, Jose Abreu,
Giuseppe Cavallaro, Alexandre Torgue, Krzysztof Kozlowski,
Conor Dooley, linux-renesas-soc, Eric Dumazet, netdev,
Andrew Lunn, devicetree
On Tue, 13 May 2025 09:33:56 +0200, Geert Uytterhoeven wrote:
> According to the bindings, the MDIO subnode should be called "mdio".
> Update the example to match this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> For dwc-qos-ethernet-4.10, the Linux driver insists on "mdio".
> For other devices, the Linux driver does not seem to care, and just
> looks for subnodes that are compatible with "snps,dwmac-mdio":
> https://elixir.bootlin.com/linux/v6.14.6/source/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c#L302
>
> Lots of DTS files are using "mdio0" (copied from the example?).
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: net: snps,dwmac: Align mdio node in example with bindings
2025-05-13 7:33 [PATCH] dt-bindings: net: snps,dwmac: Align mdio node in example with bindings Geert Uytterhoeven
2025-05-14 12:48 ` Simon Horman
2025-05-14 23:38 ` Rob Herring (Arm)
@ 2025-05-15 2:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-05-15 2:00 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, robh, krzk+dt,
conor+dt, alexandre.torgue, peppe.cavallaro, joabreu, netdev,
devicetree, linux-renesas-soc
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 13 May 2025 09:33:56 +0200 you wrote:
> According to the bindings, the MDIO subnode should be called "mdio".
> Update the example to match this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> For dwc-qos-ethernet-4.10, the Linux driver insists on "mdio".
> For other devices, the Linux driver does not seem to care, and just
> looks for subnodes that are compatible with "snps,dwmac-mdio":
> https://elixir.bootlin.com/linux/v6.14.6/source/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c#L302
>
> [...]
Here is the summary with links:
- dt-bindings: net: snps,dwmac: Align mdio node in example with bindings
https://git.kernel.org/netdev/net-next/c/685e7b1522f7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-15 1:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-13 7:33 [PATCH] dt-bindings: net: snps,dwmac: Align mdio node in example with bindings Geert Uytterhoeven
2025-05-14 12:48 ` Simon Horman
2025-05-14 23:38 ` Rob Herring (Arm)
2025-05-15 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).