From: Simon Horman <horms@kernel.org>
To: Subbaraya Sundeep <sbhatta@marvell.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, gakula@marvell.com,
hkelam@marvell.com, sgoutham@marvell.com, lcherian@marvell.com,
bbhushan2@marvell.com, jerinj@marvell.com,
netdev@vger.kernel.org
Subject: Re: [net-next v2 PATCH 2/2] octeontx2-pf: macsec: Get MACSEC capability flag from AF
Date: Wed, 14 May 2025 13:56:40 +0100 [thread overview]
Message-ID: <20250514125640.GN3339421@horms.kernel.org> (raw)
In-Reply-To: <aCMDhyuY2_B-c0CE@59cc1f87bccd>
On Tue, May 13, 2025 at 08:32:07AM +0000, Subbaraya Sundeep wrote:
Hi Subbaraya,
> Hi Simon,
>
> On 2025-05-12 at 16:37:32, Simon Horman (horms@kernel.org) wrote:
> > On Sun, May 11, 2025 at 06:52:47PM +0530, Subbaraya Sundeep wrote:
...
> > Hi Subbaraya,
> >
> > If I read things correctly otx2_setup_dev_hw_settings() is called
> > for both representors and non-representors, while otx2_probe is
> > only called for non-representors.
> >
> > If so, my question is if this patch changes behaviour for representors.
> > And, again if so, if that is intentional.
> I assume you mean VF driver for representors and PF driver for
> non-representor. Yes this is intentional. We currently do not support
> macscec offload on VFs hence I changed only PF driver. In case we want
> to support macsec offload on VFs too then otx2vf_probe also need to be
> changed like:
> otx2_set_hw_capabilities(vf);
> err = cn10k_mcs_init(vf);
Thanks for the clarification.
In that case this patch looks good ti me.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2025-05-14 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 13:22 [net-next v2 PATCH 0/2] octeontx2-pf: Do not detect MACSEC block based on silicon Subbaraya Sundeep
2025-05-11 13:22 ` [net-next v2 PATCH 1/2] octeontx2-af: Add MACSEC capability flag Subbaraya Sundeep
2025-05-14 12:55 ` Simon Horman
2025-05-11 13:22 ` [net-next v2 PATCH 2/2] octeontx2-pf: macsec: Get MACSEC capability flag from AF Subbaraya Sundeep
2025-05-12 16:37 ` Simon Horman
2025-05-13 8:32 ` Subbaraya Sundeep
2025-05-14 12:56 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514125640.GN3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).