From: Jakub Kicinski <kuba@kernel.org>
To: Wojtek Wasko <wwasko@nvidia.com>
Cc: richardcochran@gmail.com, vadim.fedorenko@linux.dev,
netdev@vger.kernel.org
Subject: Re: [PATCH] ptp: Add sysfs attribute to show clock is safe to open RO
Date: Thu, 15 May 2025 06:40:48 -0700 [thread overview]
Message-ID: <20250515064048.43b70b87@kernel.org> (raw)
In-Reply-To: <20250514143622.4104588-1-wwasko@nvidia.com>
On Wed, 14 May 2025 17:36:21 +0300 Wojtek Wasko wrote:
> Recent patches introduced in 6.15 implement permissions checks for PTP
> clocks. Prior to those, a process with readonly access could modify the
> state of PTP devices, in particular the generation and consumption of
> PPS signals.
>
> Userspace (e.g. udev) managing the ownership and permissions of device
> nodes lacks information as to whether kernel implements the necessary
> security checks and whether it is safe to expose readonly access to
> PTP devices to unprivileged users. Kernel version checks are cumbersome
> and prone to failure, especially if backports are considered [1].
>
> Add a readonly sysfs attribute to PTP clocks, "ro_safe", backed by a
> static string.
Please CC Greg on v2, maybe we're missing a trick.
Also remember to add a signoff.
prev parent reply other threads:[~2025-05-15 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 14:36 [PATCH] ptp: Add sysfs attribute to show clock is safe to open RO Wojtek Wasko
2025-05-14 14:54 ` Andrew Lunn
2025-05-14 15:25 ` Vadim Fedorenko
2025-05-15 12:48 ` Wojtek Wasko
2025-05-15 13:40 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515064048.43b70b87@kernel.org \
--to=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wwasko@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).