From: Jakub Kicinski <kuba@kernel.org>
To: Ronak Doshi <ronak.doshi@broadcom.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Guolin Yang <guolin.yang@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] vmxnet3: correctly report gso type for UDP tunnels
Date: Thu, 15 May 2025 14:25:51 -0700 [thread overview]
Message-ID: <20250515142551.1fee0440@kernel.org> (raw)
In-Reply-To: <CAP1Q3XQcPnjOYRb+G7hSDE6=GH=Yzat_oLM3PMREp-DWgfmT6w@mail.gmail.com>
On Thu, 15 May 2025 13:38:49 -0700 Ronak Doshi wrote:
> > IIRC ->encapsulation means that ->inner.. fields are valid, no?
> > And I don't see you setting any of these.
> >
> > Paolo, please keep me honest, IIUC you have very recent and very
> > relevant experience with virtio.
>
> I did not hit any issues during Vxlan and Geneve tunnel testing. I did not find
> the code which validates inner fields being set. Maybe I missed something. If
> you and Paolo think inner fields are indeed required, then I will remove these
> lines.
Not sure if the stack itself cares, but drivers look at those
fields for TSO. I see a call to skb_inner_transport_offset()
in vmxnet3_parse_hdr(). One thing to try would be to configure
the machine for forwarding so that the packet comes via LRO
and leaves via TSO.
next prev parent reply other threads:[~2025-05-15 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 21:05 [PATCH net] vmxnet3: correctly report gso type for UDP tunnels Ronak Doshi
2025-05-15 14:02 ` Jakub Kicinski
2025-05-15 20:38 ` Ronak Doshi
2025-05-15 21:25 ` Jakub Kicinski [this message]
2025-05-15 23:38 ` Ronak Doshi
2025-05-19 7:32 ` Paolo Abeni
2025-05-19 7:29 ` Paolo Abeni
2025-05-27 16:10 ` Ronak Doshi
2025-05-29 21:55 ` Ronak Doshi
2025-05-29 23:33 ` Jakub Kicinski
2025-05-30 0:50 ` Ronak Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515142551.1fee0440@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guolin.yang@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ronak.doshi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).