Re: [PATCH v3 net-next 1/9] af_unix: Factorise test_bit() for SOCK_PASSCRED and SOCK_PASSPIDFD.

[Kuniyuki Iwashima <kuniyu@amazon.com>]

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Thu, 15 May 2025 14:07:06 -0400
> Kuniyuki Iwashima wrote:
> > Currently, the same checks for SOCK_PASSCRED and SOCK_PASSPIDFD
> > are scattered across many places.
> > 
> > Let's centralise the bit tests to make the following changes cleaner.
> > 
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> > ---
> >  net/unix/af_unix.c | 37 +++++++++++++++----------------------
> >  1 file changed, 15 insertions(+), 22 deletions(-)
> > 
> > diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> > index 2ab20821d6bb..464e183ffdb8 100644
> > --- a/net/unix/af_unix.c
> > +++ b/net/unix/af_unix.c
> > @@ -765,6 +765,14 @@ static void copy_peercred(struct sock *sk, struct sock *peersk)
> >  	spin_unlock(&sk->sk_peer_lock);
> >  }
> >  
> > +static bool unix_may_passcred(const struct sock *sk)
> > +{
> > +	struct socket *sock = sk->sk_socket;
> 
> Also const?

yes, but this part is removed in patch 6, so I'd leave as is :)