Re: [PATCH v7 6/9] coredump: show supported coredump modes

Alexander Mikhalitsyn
2025-05-15T13:56:28Z

Am Do., 15. Mai 2025 um 00:04 Uhr schrieb Christian Brauner
<brauner@kernel.org>:
>
> Allow userspace to discover what coredump modes are supported.
>
> Signed-off-by: Christian Brauner <brauner@kernel.org>

Reviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>

> ---
> fs/coredump.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index bfc4a32f737c..6ee38e3da108 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -1240,6 +1240,12 @@ static int proc_dostring_coredump(const struct ctl_table *table, int write,
>
> static const unsigned int core_file_note_size_min = CORE_FILE_NOTE_SIZE_DEFAULT;
> static const unsigned int core_file_note_size_max = CORE_FILE_NOTE_SIZE_MAX;
> +static char core_modes[] = {
> + "file\npipe"
> +#ifdef CONFIG_UNIX
> + "\nsocket"
> +#endif
> +};
>
> static const struct ctl_table coredump_sysctls[] = {
> {
> @@ -1283,6 +1289,13 @@ static const struct ctl_table coredump_sysctls[] = {
> .extra1 = SYSCTL_ZERO,
> .extra2 = SYSCTL_ONE,
> },
> + {
> + .procname = "core_modes",
> + .data = core_modes,
> + .maxlen = sizeof(core_modes) - 1,
> + .mode = 0444,
> + .proc_handler = proc_dostring,
> + },
> };
>
> static int __init init_fs_coredump_sysctls(void)
>
> --
> 2.47.2
>