From: Simon Horman <horms@kernel.org>
To: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-next v1] ice: add 40G speed to Admin Command GET PORT OPTION
Date: Fri, 16 May 2025 14:05:05 +0100 [thread overview]
Message-ID: <20250516130505.GF3339421@horms.kernel.org> (raw)
In-Reply-To: <20250515091105.3005987-1-aleksandr.loktionov@intel.com>
On Thu, May 15, 2025 at 09:11:05AM +0000, Aleksandr Loktionov wrote:
> Introduce the ICE_AQC_PORT_OPT_MAX_LANE_40G constant and update the code
> to process this new option in both the devlink and the Admin Queue Command
> GET PORT OPTION (opcode 0x06EA) message, similar to existing constants like
> ICE_AQC_PORT_OPT_MAX_LANE_50G, ICE_AQC_PORT_OPT_MAX_LANE_100G, and so on.
>
> This feature allows the driver to correctly report configuration options
> for 2x40G on ICX-D LCC and other cards in the future via devlink.
>
> Example comand:
> devlink port split pci/0000:01:00.0/0 count 2
>
> Example dmesg:
> ice 0000:01:00.0: Available port split options and max port speeds (Gbps):
> ice 0000:01:00.0: Status Split Quad 0 Quad 1
> ice 0000:01:00.0: count L0 L1 L2 L3 L4 L5 L6 L7
> ice 0000:01:00.0: 2 40 - - - 40 - - -
> ice 0000:01:00.0: 2 50 - 50 - - - - -
> ice 0000:01:00.0: 4 25 25 25 25 - - - -
> ice 0000:01:00.0: 4 25 25 - - 25 25 - -
> ice 0000:01:00.0: Active 8 10 10 10 10 10 10 10 10
> ice 0000:01:00.0: 1 100 - - - - - - -
>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
...
> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> index 6488151..f2c0b28 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
> @@ -667,7 +667,8 @@ static int ice_get_port_topology(struct ice_hw *hw, u8 lport,
>
> if (max_speed == ICE_AQC_PORT_OPT_MAX_LANE_100G)
> port_topology->serdes_lane_count = 4;
> - else if (max_speed == ICE_AQC_PORT_OPT_MAX_LANE_50G)
> + else if (max_speed == ICE_AQC_PORT_OPT_MAX_LANE_50G ||
> + max_speed == ICE_AQC_PORT_OPT_MAX_LANE_40G)
nit: I think it would be better to indent the line above like this.
else if (max_speed == ICE_AQC_PORT_OPT_MAX_LANE_50G ||
max_speed == ICE_AQC_PORT_OPT_MAX_LANE_40G)
> port_topology->serdes_lane_count = 2;
> else
> port_topology->serdes_lane_count = 1;
Otherwise, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2025-05-16 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 9:11 [PATCH iwl-next v1] ice: add 40G speed to Admin Command GET PORT OPTION Aleksandr Loktionov
2025-05-16 13:05 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516130505.GF3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).