From: Jakub Kicinski <kuba@kernel.org>
To: Harshitha Ramamurthy <hramamurthy@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jeroendb@google.com, andrew+netdev@lunn.ch,
willemb@google.com, ziweixiao@google.com,
pkaligineedi@google.com, yyd@google.com, joshwash@google.com,
shailend@google.com, linux@treblig.org, thostet@google.com,
jfraker@google.com, richardcochran@gmail.com, jdamato@fastly.com,
vadim.fedorenko@linux.dev, horms@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 7/8] gve: Add support for SIOC[GS]HWTSTAMP IOCTLs
Date: Fri, 16 May 2025 18:52:25 -0700 [thread overview]
Message-ID: <20250516185225.137d0966@kernel.org> (raw)
In-Reply-To: <20250517001110.183077-8-hramamurthy@google.com>
On Sat, 17 May 2025 00:11:09 +0000 Harshitha Ramamurthy wrote:
> Subject: [PATCH net-next v2 7/8] gve: Add support for SIOC[GS]HWTSTAMP IOCTLs
Sorry for the very shallow review, the subject jumped out at me.
You're not implementing the shouty ioctl, you're adding ndos.
> + if (kernel_config->tx_type != HWTSTAMP_TX_OFF) {
> + dev_err(&priv->pdev->dev, "TX timestamping is not supported\n");
please use extack
> + return -ERANGE;
> + }
> +
> + if (kernel_config->rx_filter != HWTSTAMP_FILTER_NONE) {
> + kernel_config->rx_filter = HWTSTAMP_FILTER_ALL;
> + if (!priv->nic_ts_report) {
> + err = gve_init_clock(priv);
> + if (err) {
> + dev_err(&priv->pdev->dev,
> + "Failed to initialize GVE clock\n");
and here. Remember to remove the \n when converting.
next prev parent reply other threads:[~2025-05-17 1:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 0:11 [PATCH net-next v2 0/8] gve: Add Rx HW timestamping support Harshitha Ramamurthy
2025-05-17 0:11 ` [PATCH net-next v2 1/8] gve: Add device option for nic clock synchronization Harshitha Ramamurthy
2025-05-17 0:11 ` [PATCH net-next v2 2/8] gve: Add adminq command to report nic timestamp Harshitha Ramamurthy
2025-05-17 0:11 ` [PATCH net-next v2 3/8] gve: Add initial PTP device support Harshitha Ramamurthy
2025-05-17 0:11 ` [PATCH net-next v2 4/8] gve: Add adminq lock for queues creation and destruction Harshitha Ramamurthy
2025-05-17 0:11 ` [PATCH net-next v2 5/8] gve: Add support to query the nic clock Harshitha Ramamurthy
2025-05-17 0:11 ` [PATCH net-next v2 6/8] gve: Add rx hardware timestamp expansion Harshitha Ramamurthy
2025-05-18 21:45 ` Vadim Fedorenko
2025-05-19 18:45 ` Ziwei Xiao
2025-05-20 19:53 ` Vadim Fedorenko
2025-05-21 5:22 ` Ziwei Xiao
2025-05-17 0:11 ` [PATCH net-next v2 7/8] gve: Add support for SIOC[GS]HWTSTAMP IOCTLs Harshitha Ramamurthy
2025-05-17 1:52 ` Jakub Kicinski [this message]
2025-05-19 18:32 ` Ziwei Xiao
2025-05-17 0:11 ` [PATCH net-next v2 8/8] gve: Advertise support for rx hardware timestamping Harshitha Ramamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516185225.137d0966@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=jdamato@fastly.com \
--cc=jeroendb@google.com \
--cc=jfraker@google.com \
--cc=joshwash@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=richardcochran@gmail.com \
--cc=shailend@google.com \
--cc=thostet@google.com \
--cc=vadim.fedorenko@linux.dev \
--cc=willemb@google.com \
--cc=yyd@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).