[PATCH net-next] net: enetc: fix the error handling in enetc4_pf_netdev_create()

[PATCH net-next] net: enetc: fix the error handling in enetc4_pf_netdev_create()

[Wei Fang]

Fix the handling of err_wq_init and err_reg_netdev paths in
enetc4_pf_netdev_create() function.

Fixes: 6c5bafba347b ("net: enetc: add MAC filtering for i.MX95 ENETC PF")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 drivers/net/ethernet/freescale/enetc/enetc4_pf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
index c16378eb50bc..b3dc1afeefd1 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
@@ -971,8 +971,9 @@ static int enetc4_pf_netdev_create(struct enetc_si *si)
 	return 0;
 
 err_reg_netdev:
-	enetc4_link_deinit(priv);
+	destroy_workqueue(si->workqueue);
 err_wq_init:
+	enetc4_link_deinit(priv);
 err_link_init:
 	enetc_free_msix(priv);
 err_alloc_msix:
-- 
2.34.1

Re: [PATCH net-next] net: enetc: fix the error handling in enetc4_pf_netdev_create()

[Simon Horman]

On Fri, May 16, 2025 at 01:27:34PM +0800, Wei Fang wrote:
> Fix the handling of err_wq_init and err_reg_netdev paths in
> enetc4_pf_netdev_create() function.
> 
> Fixes: 6c5bafba347b ("net: enetc: add MAC filtering for i.MX95 ENETC PF")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>

Reviewed-by: Simon Horman <horms@kernel.org>

I note that this is a fox for a commit is present in net-next but not net.
Thus a Fixes tag + target of net-next is appropriate.

Re: [PATCH net-next] net: enetc: fix the error handling in enetc4_pf_netdev_create()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 16 May 2025 13:27:34 +0800 you wrote:
> Fix the handling of err_wq_init and err_reg_netdev paths in
> enetc4_pf_netdev_create() function.
> 
> Fixes: 6c5bafba347b ("net: enetc: add MAC filtering for i.MX95 ENETC PF")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
>  drivers/net/ethernet/freescale/enetc/enetc4_pf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [net-next] net: enetc: fix the error handling in enetc4_pf_netdev_create()
    https://git.kernel.org/netdev/net-next/c/b98b70c103de

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html