Re: [PATCH net-next 09/10] nvme-tcp: use crc32c() and skb_copy_and_crc32c_datagram_iter()

Sagi Grimberg
2025-05-17T09:58:38Z

> #include "nvme.h"
> #include "fabrics.h"
> @@ -166,12 +166,12 @@ struct nvme_tcp_queue {
> bool rd_enabled;
>
> bool hdr_digest;
> bool data_digest;
> bool tls_enabled;
> - struct ahash_request *rcv_hash;
> - struct ahash_request *snd_hash;
> + u32 rcv_crc;
> + u32 snd_crc;

Let's call it rcv_dgst (recv digest) and snd_dgst (send digest).
Other than that, looks good to me.

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>