* Re: [PATCH v5 7/7] fs: introduce file_getattr and file_setattr syscalls
[not found] <20250513-xattrat-syscall-v5-7-22bb9c6c767f@kernel.org>
@ 2025-05-13 22:39 ` kernel test robot
2025-05-18 11:26 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-05-13 22:39 UTC (permalink / raw)
To: Andrey Albershteyn, Richard Henderson, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Geert Uytterhoeven, Michal Simek,
Thomas Bogendoerfer, James E.J. Bottomley, Helge Deller,
Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N Rao, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle,
Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz,
David S. Miller, Andreas Larsson, Andy Lutomirski,
Thomas Gleixner, Ingo Molnar, Borislav Petkov
Cc: oe-kbuild-all, netdev
Hi Andrey,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 0d8d44db295ccad20052d6301ef49ff01fb8ae2d]
url: https://github.com/intel-lab-lkp/linux/commits/Andrey-Albershteyn/fs-split-fileattr-related-helpers-into-separate-file/20250513-172128
base: 0d8d44db295ccad20052d6301ef49ff01fb8ae2d
patch link: https://lore.kernel.org/r/20250513-xattrat-syscall-v5-7-22bb9c6c767f%40kernel.org
patch subject: [PATCH v5 7/7] fs: introduce file_getattr and file_setattr syscalls
config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20250514/202505140614.Hqk46aA8-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250514/202505140614.Hqk46aA8-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505140614.Hqk46aA8-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> <stdin>:1618:2: warning: #warning syscall file_getattr not implemented [-Wcpp]
>> <stdin>:1621:2: warning: #warning syscall file_setattr not implemented [-Wcpp]
--
>> <stdin>:1618:2: warning: #warning syscall file_getattr not implemented [-Wcpp]
>> <stdin>:1621:2: warning: #warning syscall file_setattr not implemented [-Wcpp]
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v5 7/7] fs: introduce file_getattr and file_setattr syscalls
[not found] <20250513-xattrat-syscall-v5-7-22bb9c6c767f@kernel.org>
2025-05-13 22:39 ` [PATCH v5 7/7] fs: introduce file_getattr and file_setattr syscalls kernel test robot
@ 2025-05-18 11:26 ` kernel test robot
2025-05-19 8:06 ` Heiko Carstens
1 sibling, 1 reply; 3+ messages in thread
From: kernel test robot @ 2025-05-18 11:26 UTC (permalink / raw)
To: Andrey Albershteyn, Richard Henderson, Matt Turner, Russell King,
Catalin Marinas, Will Deacon, Geert Uytterhoeven, Michal Simek,
Thomas Bogendoerfer, James E.J. Bottomley, Helge Deller,
Madhavan Srinivasan, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N Rao, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Christian Borntraeger, Sven Schnelle,
Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz,
David S. Miller, Andreas Larsson, Andy Lutomirski,
Thomas Gleixner, Ingo Molnar, Borislav Petkov
Cc: oe-kbuild-all, netdev
Hi Andrey,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 0d8d44db295ccad20052d6301ef49ff01fb8ae2d]
url: https://github.com/intel-lab-lkp/linux/commits/Andrey-Albershteyn/fs-split-fileattr-related-helpers-into-separate-file/20250513-172128
base: 0d8d44db295ccad20052d6301ef49ff01fb8ae2d
patch link: https://lore.kernel.org/r/20250513-xattrat-syscall-v5-7-22bb9c6c767f%40kernel.org
patch subject: [PATCH v5 7/7] fs: introduce file_getattr and file_setattr syscalls
config: s390-randconfig-r112-20250518 (https://download.01.org/0day-ci/archive/20250518/202505181900.UGh2tVRs-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 8.5.0
reproduce: (https://download.01.org/0day-ci/archive/20250518/202505181900.UGh2tVRs-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505181900.UGh2tVRs-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
>> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
>> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
>> fs/file_attr.c:362:1: sparse: sparse: Using plain integer as NULL pointer
fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
fs/file_attr.c:416:1: sparse: sparse: Using plain integer as NULL pointer
vim +362 fs/file_attr.c
361
> 362 SYSCALL_DEFINE5(file_getattr, int, dfd, const char __user *, filename,
363 struct fsxattr __user *, ufsx, size_t, usize,
364 unsigned int, at_flags)
365 {
366 struct fileattr fa = {};
367 struct path filepath __free(path_put) = {};
368 int error;
369 unsigned int lookup_flags = 0;
370 struct filename *name;
371 struct fsxattr fsx = {};
372
373 BUILD_BUG_ON(sizeof(struct fsxattr) < FSXATTR_SIZE_VER0);
374 BUILD_BUG_ON(sizeof(struct fsxattr) != FSXATTR_SIZE_LATEST);
375
376 if ((at_flags & ~(AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH)) != 0)
377 return -EINVAL;
378
379 if (!(at_flags & AT_SYMLINK_NOFOLLOW))
380 lookup_flags |= LOOKUP_FOLLOW;
381
382 if (usize > PAGE_SIZE)
383 return -E2BIG;
384
385 if (usize < FSXATTR_SIZE_VER0)
386 return -EINVAL;
387
388 name = getname_maybe_null(filename, at_flags);
389 if (IS_ERR(name))
390 return PTR_ERR(name);
391
392 if (!name && dfd >= 0) {
393 CLASS(fd, f)(dfd);
394
395 filepath = fd_file(f)->f_path;
396 path_get(&filepath);
397 } else {
398 error = filename_lookup(dfd, name, lookup_flags, &filepath,
399 NULL);
400 putname(name);
401 if (error)
402 return error;
403 }
404
405 error = vfs_fileattr_get(filepath.dentry, &fa);
406 if (error)
407 return error;
408
409 fileattr_to_fsxattr(&fa, &fsx);
410 error = copy_struct_to_user(ufsx, usize, &fsx, sizeof(struct fsxattr),
411 NULL);
412
413 return error;
414 }
415
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread