[PATCH] net: ethernet: ti: am65-cpsw: Lower random mac address error print to info

[PATCH] net: ethernet: ti: am65-cpsw: Lower random mac address error print to info

[Nishanth Menon]

Using random mac address is not an error since the driver continues to
function, it should be informative that the system has not assigned
a MAC address. This is inline with other drivers such as ax88796c,
dm9051 etc. Drop the error level to info level.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

This is esp irritating on platforms such as J721E-IDK-GW which has a
bunch of ethernet interfaces, and not all of them have MAC address
assigned from Efuse.
Example log (next-20250515):
https://gist.github.com/nmenon/8edbc1773c150a5be69f5b700d907ceb#file-j721e-idk-gw-L1588

 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index 1e6d2335293d..30665ffe78cf 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -2685,7 +2685,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
 							port->slave.mac_addr);
 			if (!is_valid_ether_addr(port->slave.mac_addr)) {
 				eth_random_addr(port->slave.mac_addr);
-				dev_err(dev, "Use random MAC address\n");
+				dev_info(dev, "Use random MAC address\n");
 			}
 		}
 
-- 
2.47.0

Re: [PATCH] net: ethernet: ti: am65-cpsw: Lower random mac address error print to info

[Simon Horman]

On Fri, May 16, 2025 at 07:26:55AM -0500, Nishanth Menon wrote:
> Using random mac address is not an error since the driver continues to
> function, it should be informative that the system has not assigned
> a MAC address. This is inline with other drivers such as ax88796c,
> dm9051 etc. Drop the error level to info level.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> This is esp irritating on platforms such as J721E-IDK-GW which has a
> bunch of ethernet interfaces, and not all of them have MAC address
> assigned from Efuse.
> Example log (next-20250515):
> https://gist.github.com/nmenon/8edbc1773c150a5be69f5b700d907ceb#file-j721e-idk-gw-L1588

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH] net: ethernet: ti: am65-cpsw: Lower random mac address error print to info

[Roger Quadros]

On 16/05/2025 15:26, Nishanth Menon wrote:
> Using random mac address is not an error since the driver continues to
> function, it should be informative that the system has not assigned
> a MAC address. This is inline with other drivers such as ax88796c,
> dm9051 etc. Drop the error level to info level.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> This is esp irritating on platforms such as J721E-IDK-GW which has a
> bunch of ethernet interfaces, and not all of them have MAC address
> assigned from Efuse.
> Example log (next-20250515):
> https://gist.github.com/nmenon/8edbc1773c150a5be69f5b700d907ceb#file-j721e-idk-gw-L1588
> 

Reviewed-by: Roger Quadros <rogerq@kernel.org>

Re: [PATCH] net: ethernet: ti: am65-cpsw: Lower random mac address error print to info

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 16 May 2025 07:26:55 -0500 you wrote:
> Using random mac address is not an error since the driver continues to
> function, it should be informative that the system has not assigned
> a MAC address. This is inline with other drivers such as ax88796c,
> dm9051 etc. Drop the error level to info level.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> 
> [...]

Here is the summary with links:
  - net: ethernet: ti: am65-cpsw: Lower random mac address error print to info
    https://git.kernel.org/netdev/net/c/50980d8da71a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html