From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
David Ahern <dsahern@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Shuah Khan <shuah@kernel.org>,
sdf@fomichev.me, ap420073@gmail.com, praan@google.com,
shivajikant@google.com
Subject: Re: [PATCH net-next v1 5/9] net: devmem: ksft: add ipv4 support
Date: Mon, 19 May 2025 16:48:46 -0700 [thread overview]
Message-ID: <20250519164846.40cd01e4@kernel.org> (raw)
In-Reply-To: <20250519023517.4062941-6-almasrymina@google.com>
On Mon, 19 May 2025 02:35:13 +0000 Mina Almasry wrote:
> + addr = cfg.addr_v[ipver]
> + if ipver == "6":
> + addr = "[" + addr + "]"
You want baddr ?
https://web.git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/tools/testing/selftests/drivers/net/lib/py/env.py#n155
In general you should use cfg.addr, cfg.addr_remote and self.addr_ipver
if you don't care about what IP version env provides.
If you want to test specifically v4 or v6 they should be separate test
cases (doesn't sound like that's your intention here tho)
next prev parent reply other threads:[~2025-05-19 23:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 2:35 [PATCH net-next v1 0/9] Devmem TCP minor cleanups and ksft improvements Mina Almasry
2025-05-19 2:35 ` [PATCH net-next v1 1/9] net: devmem: move list_add to net_devmem_bind_dmabuf Mina Almasry
2025-05-19 6:45 ` Taehee Yoo
2025-05-19 2:35 ` [PATCH net-next v1 2/9] page_pool: fix ugly page_pool formatting Mina Almasry
2025-05-19 2:35 ` [PATCH net-next v1 3/9] net: devmem: preserve sockc_err Mina Almasry
2025-05-19 15:21 ` Stanislav Fomichev
2025-05-19 2:35 ` [PATCH net-next v1 4/9] net: devmem: ksft: remove ksft_disruptive Mina Almasry
2025-05-19 15:25 ` Stanislav Fomichev
2025-05-19 17:30 ` Mina Almasry
2025-05-19 20:18 ` Stanislav Fomichev
2025-05-19 23:41 ` Jakub Kicinski
2025-05-19 2:35 ` [PATCH net-next v1 5/9] net: devmem: ksft: add ipv4 support Mina Almasry
2025-05-19 15:32 ` Stanislav Fomichev
2025-05-19 17:31 ` Mina Almasry
2025-05-19 20:26 ` Stanislav Fomichev
2025-05-19 23:48 ` Jakub Kicinski [this message]
2025-05-19 2:35 ` [PATCH net-next v1 6/9] net: devmem: ksft: add exit_wait to make rx test pass Mina Almasry
2025-05-19 15:32 ` Stanislav Fomichev
2025-05-19 2:35 ` [PATCH net-next v1 7/9] net: devmem: ksft: add 5 tuple FS support Mina Almasry
2025-05-19 15:37 ` Stanislav Fomichev
2025-05-19 17:32 ` Mina Almasry
2025-05-19 20:26 ` Stanislav Fomichev
2025-05-19 2:35 ` [PATCH net-next v1 8/9] net: devmem: ksft: upgrade rx test to send 1K data Mina Almasry
2025-05-19 15:37 ` Stanislav Fomichev
2025-05-19 2:35 ` [PATCH net-next v1 9/9] net: devmem: ncdevmem: remove unused variable Mina Almasry
2025-05-19 15:37 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250519164846.40cd01e4@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praan@google.com \
--cc=sdf@fomichev.me \
--cc=shivajikant@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).