netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	netdev@vger.kernel.org, Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [PATCH 0/2] virtio: Fixes for TX ring sizing and resize error reporting
Date: Tue, 20 May 2025 13:05:24 +0200	[thread overview]
Message-ID: <20250520110526.635507-1-lvivier@redhat.com> (raw)

This patch series contains two fixes for the virtio subsystem.

The first patch fixes an error reporting bug in virtio_ring's
virtqueue_resize() function. Previously, errors from internal resize
helpers could be masked if the subsequent re-enabling of the virtqueue
succeeded. This patch restores the correct error propagation, ensuring that
callers of virtqueue_resize() are properly informed of underlying resize
failures.

The second patch addresses a reliability issue in virtio_net where the TX
ring size could be configured too small, potentially leading to
persistently stopped queues and degraded performance. It enforces a
minimum TX ring size to ensure there's always enough space for at least one
maximally-fragmented packet plus an additional slot.

Laurent Vivier (2):
  virtio_ring: Fix error reporting in virtqueue_resize
  virtio_net: Enforce minimum TX ring size for reliability

 drivers/net/virtio_net.c     | 6 ++++++
 drivers/virtio/virtio_ring.c | 8 ++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

-- 
2.49.0



             reply	other threads:[~2025-05-20 11:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 11:05 Laurent Vivier [this message]
2025-05-20 11:05 ` [PATCH 1/2] virtio_ring: Fix error reporting in virtqueue_resize Laurent Vivier
2025-05-21  1:00   ` Jason Wang
2025-05-21  7:25     ` Laurent Vivier
2025-05-21  9:25   ` Xuan Zhuo
2025-05-20 11:05 ` [PATCH 2/2] virtio_net: Enforce minimum TX ring size for reliability Laurent Vivier
2025-05-21  1:01   ` Jason Wang
2025-05-21  7:45     ` Laurent Vivier
2025-05-21  8:39       ` Michael S. Tsirkin
2025-05-21  8:47         ` Laurent Vivier
2025-05-22  1:55       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250520110526.635507-1-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).