netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, jiri@resnulli.us, jhs@mojatatu.com,
	Mingi Cho <mincho@theori.io>
Subject: Re: [Patch net 2/2] selftests/tc-testing: Add an HFSC qlen accounting test
Date: Wed, 21 May 2025 10:18:59 +0100	[thread overview]
Message-ID: <20250521091859.GV365796@horms.kernel.org> (raw)
In-Reply-To: <20250518222038.58538-3-xiyou.wangcong@gmail.com>

On Sun, May 18, 2025 at 03:20:38PM -0700, Cong Wang wrote:
> This test reproduces a scenario where HFSC queue length and backlog accounting
> can become inconsistent when a peek operation triggers a dequeue and possible
> drop before the parent qdisc updates its counters. The test sets up a DRR root
> qdisc with an HFSC class, netem, and blackhole children, and uses Scapy to
> inject a packet. It helps to verify that HFSC correctly tracks qlen and backlog
> even when packets are dropped during peek-induced dequeue.
> 
> Cc: Mingi Cho <mincho@theori.io>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>


  reply	other threads:[~2025-05-21  9:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-18 22:20 [Patch net 0/2] net_sched: Fix HFSC qlen/backlog accounting bug and add selftest Cong Wang
2025-05-18 22:20 ` [Patch net 1/2] sch_hfsc: Fix qlen accounting bug when using peek in hfsc_enqueue() Cong Wang
2025-05-21  9:18   ` Simon Horman
2025-05-18 22:20 ` [Patch net 2/2] selftests/tc-testing: Add an HFSC qlen accounting test Cong Wang
2025-05-21  9:18   ` Simon Horman [this message]
2025-05-21 11:07 ` [Patch net 0/2] net_sched: Fix HFSC qlen/backlog accounting bug and add selftest Jamal Hadi Salim
2025-05-22  9:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250521091859.GV365796@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=mincho@theori.io \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).