From: Jakub Kicinski <kuba@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Network Development <netdev@vger.kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Hillf Danton <hdanton@sina.com>,
Stanislav Fomichev <stfomichev@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net] team: replace team lock with rtnl lock
Date: Wed, 21 May 2025 11:00:24 -0700 [thread overview]
Message-ID: <20250521110024.64f5e422@kernel.org> (raw)
In-Reply-To: <d4047311-5644-4884-84c0-059bbb9e98ee@I-love.SAKURA.ne.jp>
On Wed, 21 May 2025 22:38:55 +0900 Tetsuo Handa wrote:
> syzbot is reporting locking order problem between wiphy and team.
> As per Jiri Pirko's comment, let's check whether all callers are
> already holding rtnl lock. This patch will help simplifying locking
> dependency if all callers are already holding rtnl lock.
>
> Reported-by: syzbot+705c61d60b091ef42c04@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=705c61d60b091ef42c04
> Suggested-by: Jiri Pirko <jiri@resnulli.us>
I don't think Jiri suggested it, he provided a review and asked
questions. Suggest means he is the proponent of the patch.
And as he pointed out this patch promptly generates all sort
of locking warnings, please test this properly.
next prev parent reply other threads:[~2025-05-21 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 13:38 [PATCH net] team: replace team lock with rtnl lock Tetsuo Handa
2025-05-21 18:00 ` Jakub Kicinski [this message]
2025-05-22 1:00 ` Tetsuo Handa
2025-05-22 13:47 ` Tetsuo Handa
2025-06-20 23:20 ` Stanislav Fomichev
2025-06-21 16:27 ` Tetsuo Handa
2025-05-22 10:04 ` Jiri Pirko
-- strict thread matches above, loose matches on Subject: below --
2025-06-23 15:31 Stanislav Fomichev
2025-06-25 22:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521110024.64f5e422@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hdanton@sina.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=stfomichev@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).