netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: cel@kernel.org
To: Trond Myklebust <trond.myklebust@hammerspace.com>,
	Anna Schumaker <anna@kernel.org>
Cc: Mike Snitzer <snitzer@kernel.org>,
	Thomas Haynes <loghyr@hammerspace.com>,
	<linux-nfs@vger.kernel.org>, <netdev@vger.kernel.org>,
	<kernel-tls-handshake@lists.linux.dev>,
	Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v2 0/2] Avoid hang when mounting xprtsec=[m]tls
Date: Wed, 21 May 2025 16:34:12 -0400	[thread overview]
Message-ID: <20250521203414.889931-1-cel@kernel.org> (raw)

From: Chuck Lever <chuck.lever@oracle.com>

An NFS mount request can sometimes hang when TLS is requested.
This series attempts to address that.

I've checked on a couple of things since v1.

 - Why doesn't the Linux kernel SunRPC client already poll just
   after connecting? Typically the SunRPC client does not expect
   an RPC Reply (ie, any ingress traffic) until it has sent an RPC
   Call first. RPC-with-TLS has changed that scenario a bit.

 - Is this an issue for other in-kernel TLS consumers? It is. But
   the only other in-kernel TLS consumer at the moment is NVMe over
   TCP, and it already polls after a successful connection, for
   other reasons.

Changes since v1:
- Include Mike's R-b and T-b tags in 1/2
- Clean up dead code noticed while testing

Chuck Lever (2):
  SUNRPC: Prevent hang on NFS mount with xprtsec=[m]tls
  SUNRPC: Remove dead code from xs_tcp_tls_setup_socket()

 net/sunrpc/xprtsock.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-05-21 20:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21 20:34 cel [this message]
2025-05-21 20:34 ` [PATCH v2 1/2] SUNRPC: Prevent hang on NFS mount with xprtsec=[m]tls cel
2025-05-21 20:34 ` [PATCH v2 2/2] SUNRPC: Remove dead code from xs_tcp_tls_setup_socket() cel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250521203414.889931-1-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=kernel-tls-handshake@lists.linux.dev \
    --cc=linux-nfs@vger.kernel.org \
    --cc=loghyr@hammerspace.com \
    --cc=netdev@vger.kernel.org \
    --cc=snitzer@kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).