netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: Michael Chan <michael.chan@broadcom.com>,
	davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch,
	pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net 3/3] bnxt_en: Update MRU and RSS table of RSS contexts on queue reset
Date: Thu, 22 May 2025 08:26:50 -0700	[thread overview]
Message-ID: <20250522082650.3c4a5bb2@kernel.org> (raw)
In-Reply-To: <423fd162-d08e-467e-834d-2eb320db9ba1@davidwei.uk>

On Thu, 22 May 2025 12:01:34 +0100 David Wei wrote:
> On 5/20/25 19:29, Michael Chan wrote:
> > On Tue, May 20, 2025 at 7:17 PM Jakub Kicinski <kuba@kernel.org> wrote:  
> >> "reliable" is a bit of a big word that some people would reserve
> >> for code which is production tested or at the very least very
> >> heavily validated.  
> > 
> > FWIW, queue_mgmt_ops was heavily tested by Somnath under heavy traffic
> > conditions.  Obviously RSS contexts were not included during testing
> > and this problem was missed.  
> 
> IIRC from the initial testing w/ Somnath even though the VNICs are reset
> the traffic on unrelated queues are unaffected.

How did you check that? IIUC the device does not currently report
packet loss due to MRU clamp (!?!)

> If we ensure that is the cse with this patchset, would that resolve
> your concerns Jakub?

For ZC we expect the queues to be taken out of the main context.
IIUC it'd be a significant improvement over the status quo if
we could check which contexts the queue is in (incl. context 0)
and only clamp MRU on those.

  reply	other threads:[~2025-05-22 15:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 20:41 [PATCH net 0/3] bnxt_en: 2 bug fixes Michael Chan
2025-05-19 20:41 ` [PATCH net 1/3] bnxt_en: Fix netdev locking in ULP IRQ functions Michael Chan
2025-05-20 14:41   ` Simon Horman
2025-05-21  2:10   ` Jakub Kicinski
2025-05-19 20:41 ` [PATCH net 2/3] bnxt_en: Add a helper function to configure MRU and RSS Michael Chan
2025-05-20 14:41   ` Simon Horman
2025-05-20 14:57   ` David Wei
2025-05-19 20:41 ` [PATCH net 3/3] bnxt_en: Update MRU and RSS table of RSS contexts on queue reset Michael Chan
2025-05-20 14:42   ` Simon Horman
2025-05-20 14:59   ` David Wei
2025-05-21  1:28   ` Jakub Kicinski
2025-05-21  1:38     ` Michael Chan
2025-05-21  1:51       ` Jakub Kicinski
2025-05-21  2:10         ` Michael Chan
2025-05-21  2:17           ` Jakub Kicinski
2025-05-21  2:29             ` Michael Chan
2025-05-22 11:01               ` David Wei
2025-05-22 15:26                 ` Jakub Kicinski [this message]
2025-05-27 15:37                   ` David Wei
2025-05-27 16:50                     ` Michael Chan
2025-05-21  2:20 ` [PATCH net 0/3] bnxt_en: 2 bug fixes patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2025-06-13 23:18 [PATCH net 0/3] bnxt_en: Bug fixes Michael Chan
2025-06-13 23:18 ` [PATCH net 3/3] bnxt_en: Update MRU and RSS table of RSS contexts on queue reset Michael Chan
2025-06-16 13:38   ` Simon Horman
2025-06-16 17:40     ` Michael Chan
2025-06-16 20:48       ` Jakub Kicinski
2025-06-16 21:00         ` Michael Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250522082650.3c4a5bb2@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=dw@davidwei.uk \
    --cc=edumazet@google.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).