From: Yajun Deng <yajun.deng@linux.dev>
To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Yajun Deng <yajun.deng@linux.dev>
Subject: [PATCH net-next] net: phy: Synchronize c45_ids to phy_id
Date: Thu, 22 May 2025 21:19:18 +0800 [thread overview]
Message-ID: <20250522131918.31454-1-yajun.deng@linux.dev> (raw)
The phy_id_show() function emit the phy_id for the phy device. If the phy
device is a c45 device, the phy_id is empty. In other words, phy_id_show()
only works with the c22 device.
Synchronize c45_ids to phy_id, phy_id_show() will work with both the c22
and c45 devices.
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
drivers/net/phy/phy_device.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 2eb735e68dd8..6fed3e84e1a6 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -690,8 +690,12 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, u32 phy_id,
dev->pma_extable = -ENODATA;
dev->is_c45 = is_c45;
dev->phy_id = phy_id;
- if (c45_ids)
+ if (c45_ids) {
dev->c45_ids = *c45_ids;
+ dev->phy_id = dev->c45_ids.device_ids[MDIO_MMD_PMAPMD];
+ if (!dev->phy_id)
+ dev->phy_id = dev->c45_ids.device_ids[MDIO_MMD_PCS];
+ }
dev->irq = bus->irq[addr];
dev_set_name(&mdiodev->dev, PHY_ID_FMT, bus->id, addr);
--
2.25.1
next reply other threads:[~2025-05-22 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 13:19 Yajun Deng [this message]
2025-05-22 13:26 ` [PATCH net-next] net: phy: Synchronize c45_ids to phy_id Russell King (Oracle)
2025-05-22 13:39 ` Andrew Lunn
2025-05-23 2:10 ` Yajun Deng
2025-05-23 13:03 ` Andrew Lunn
2025-05-23 17:39 ` Russell King (Oracle)
2025-05-23 17:37 ` Russell King (Oracle)
2025-05-24 1:36 ` Yajun Deng
2025-05-28 6:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522131918.31454-1-yajun.deng@linux.dev \
--to=yajun.deng@linux.dev \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).