From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 596E6221730 for ; Fri, 23 May 2025 23:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748041542; cv=none; b=H2UE/tTmfitM7qU2NiYx/5UFYW0lsqfsKTWrIhNHIL2/zzCYDR4Z83hh69nnsT+E1CTTpyKB4l+QqlKrXvKpzzlORzNhA4jyjvV9rtC1ieAWNw89Eykn6FAqKN+8HRoYYx3CHuT1k+lgpLXEfFzL4AhZQGY2P8xszxtzs+gi0qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748041542; c=relaxed/simple; bh=ldkQQKsDkGAhHJXZx571WMeCR3RMcX+z4Wvjc5zN2jE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TwjhPmUTYWpTH//v6yoNOkGqu0ve1XMQT/HBTJvMyG0N4yLAifDpLsZiO8Nq+J9dIdFa3VrQBU8xq1X6ZmTVfTy0/aUEV56Nbo1imNL9VC/6iRdJ9Ir3jVFrLLTnVaSg8k97MAn5p5G4pQteE/8PuMxYidkxeDWM1pX3rhkUtgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Ru7gkK7Q; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--almasrymina.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ru7gkK7Q" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-231c326fe2bso3888985ad.0 for ; Fri, 23 May 2025 16:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748041541; x=1748646341; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=eFit4se3dsmsa9HWMx2TSuaow40Adh4DQRq38+N1c8s=; b=Ru7gkK7Q/9ilHmYkRovcKA4t5aseVYMqUiUXWsbTN7fud/hNj5yG3caOnJ6WowidM4 J4Y9PZtBcYGPTe4kdufPdcYhejQjKTfnxoI0/nMBMSaw2woSl9DXkLRwBRth3K9YwQ/c q8xS1U1r2opOnvf5UlSLHFStWpTMIkv/b/cfmYN7UK1WG4IsmXNZ5uNwyDycRFY+wfu2 5MJIDDGRWBg2rCOm3cnO73U09UOaTb5e/0QowOpggt421JTLo1DIn3SINeTEBZaYFVLc R7Szy4nBIgzabB7Fnl9q22dUXwQGG94kFKRbeDW147lRSxz+Nc7+kxoGQkOZw1w0ElQ8 IuQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748041541; x=1748646341; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eFit4se3dsmsa9HWMx2TSuaow40Adh4DQRq38+N1c8s=; b=Zwd5mKUc2iByiuxBgmoczBCLoy110lAA0cGnNW02S9lok55xd4OFRD4nJP+/ecHLRZ 7SHoYReY7VyUuuPTTD3A6dwRzEMOW/3MBRzbM/ZrXKyW0weNmr+vgIcUW/hlHnkhzOVY AEdHbSqY3N4IR4V7mI/QeVzpmJIbZwhz4PHGNYWXsjYCLV/Xmrg0VnE1CxHmGobcUrT3 n5yf9UpyY9JiZajKd41EhyyKGbHZakNiPOOO3UJaEZy0ShCKM7FBLY1aNDEp+GrPcqZR +tVjDVgQI8+mA3VjGhMFWnEbZV19FOxiMJGJvKE2yzsbkkl1SaSCyc84nK6i1uasEDMO PyHA== X-Gm-Message-State: AOJu0YzqH/4GxZbuVnh1c2wM58rcb6ohKolcC6NqhRHS46TUEZ49khjv TAH6M7ttcrg49C2v39ZIxkhpnev0mGpLj4Tn4dvXIzFsshyueNgMRPt2c4MmyWJkAxJiL4gqpFm WN733KbM8u1FSi6ugZmXqrJ6+toFUwoM3PGquwrqPcaxCVF1xXZL8Mqv/xEmc3CQe+BkSxL8nUB q2JRDdnzk5hHLTOLDEGJ5ateIwUwI8NbrbG30SNIQ2NIy8WfIH7fvMFvWagSJX21E= X-Google-Smtp-Source: AGHT+IHVEbxlP+HY5bODAxLKx8PUqiPk9HlkasKey/MBvVDDURED0/am87bZ3OsPQT+WnaEFbk9KFBHAAnfm2vQgGQ== X-Received: from plbjk15.prod.google.com ([2002:a17:903:330f:b0:233:fdae:780f]) (user=almasrymina job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:3d0e:b0:231:7f29:bda0 with SMTP id d9443c01a7336-23414fca909mr16630345ad.52.1748041540566; Fri, 23 May 2025 16:05:40 -0700 (PDT) Date: Fri, 23 May 2025 23:05:23 +0000 In-Reply-To: <20250523230524.1107879-1-almasrymina@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250523230524.1107879-1-almasrymina@google.com> X-Mailer: git-send-email 2.49.0.1151.ga128411c76-goog Message-ID: <20250523230524.1107879-8-almasrymina@google.com> Subject: [PATCH net-next v2 7/8] net: devmem: ksft: upgrade rx test to send 1K data From: Mina Almasry To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Mina Almasry , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jesper Dangaard Brouer , Ilias Apalodimas , Neal Cardwell , Kuniyuki Iwashima , David Ahern , Andrew Lunn , Shuah Khan , sdf@fomichev.me, ap420073@gmail.com, praan@google.com, shivajikant@google.com Content-Type: text/plain; charset="UTF-8" The current test just sends "hello\nworld" and verifies that is the string received on the RX side. That is fine, but improve the test a bit by sending 1K data. The test should be improved further to send more data, but for now this should be a welcome improvement. The test will send a repeating pattern of 0x01, 0x02, ... 0x06. The ncdevmem `-v 7` flag will verify this pattern. ncdevmem will provide useful debugging info when the test fails, such as the frags received and verified fine, and which frag exactly failed, what was the expected byte pattern, and what is the actual byte pattern received. All this debug information will be useful when the test fails. Signed-off-by: Mina Almasry Acked-by: Stanislav Fomichev --- tools/testing/selftests/drivers/net/hw/devmem.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/drivers/net/hw/devmem.py b/tools/testing/selftests/drivers/net/hw/devmem.py index 553ebf669a71..0484bda63886 100755 --- a/tools/testing/selftests/drivers/net/hw/devmem.py +++ b/tools/testing/selftests/drivers/net/hw/devmem.py @@ -24,13 +24,15 @@ def check_rx(cfg) -> None: require_devmem(cfg) port = rand_port() - listen_cmd = f"{cfg.bin_local} -l -f {cfg.ifname} -s {cfg.addr} -p {port} -c {cfg.remote_addr}" + socat = f"socat -u - TCP{cfg.addr_ipver}:{cfg.addr}:{port},bind={cfg.remote_addr}:{port}" + listen_cmd = f"{cfg.bin_local} -l -f {cfg.ifname} -s {cfg.addr} -p {port} -c {cfg.remote_addr} -v 7" with bkg(listen_cmd, exit_wait=True) as ncdevmem: wait_port_listen(port) - cmd(f"echo -e \"hello\\nworld\"| socat -u - TCP{cfg.addr_ipver}:{cfg.addr}:{port},bind={cfg.remote_addr}:{port}", host=cfg.remote, shell=True) + cmd(f"yes $(echo -e \x01\x02\x03\x04\x05\x06) | \ + head -c 1K | {socat}", host=cfg.remote, shell=True) - ksft_eq(ncdevmem.stdout.strip(), "hello\nworld") + ksft_eq(ncdevmem.ret, 0) @ksft_disruptive -- 2.49.0.1151.ga128411c76-goog