netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net: mctp: start tx queue on netdev open
@ 2025-05-26  2:44 Jeremy Kerr
  2025-05-28  0:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Kerr @ 2025-05-26  2:44 UTC (permalink / raw)
  To: Matt Johnston, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni
  Cc: Nitin Singh, netdev

We stop queues in ndo_stop, so they need to be restarted in ndo_open.
This allows us to resume tx after a link down/up cycle.

Suggested-by: Nitin Singh <nitsingh@nvidia.com>
Fixes: 0791c0327a6e ("net: mctp: Add MCTP USB transport driver")
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
---
 drivers/net/mctp/mctp-usb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mctp/mctp-usb.c b/drivers/net/mctp/mctp-usb.c
index e8d4b01c3f34588fb8df97e550f35708c6582344..775a386d0aca1242e5d3c8a750c1d0825341caa6 100644
--- a/drivers/net/mctp/mctp-usb.c
+++ b/drivers/net/mctp/mctp-usb.c
@@ -257,6 +257,8 @@ static int mctp_usb_open(struct net_device *dev)
 
 	WRITE_ONCE(mctp_usb->stopped, false);
 
+	netif_start_queue(dev);
+
 	return mctp_usb_rx_queue(mctp_usb, GFP_KERNEL);
 }
 

---
base-commit: 5cdb2c77c4c3d36bdee83d9231649941157f8204
change-id: 20250526-dev-mctp-usb-9c2f4ed33302

Best regards,
-- 
Jeremy Kerr <jk@codeconstruct.com.au>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: mctp: start tx queue on netdev open
  2025-05-26  2:44 [PATCH net] net: mctp: start tx queue on netdev open Jeremy Kerr
@ 2025-05-28  0:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-05-28  0:50 UTC (permalink / raw)
  To: Jeremy Kerr
  Cc: matt, andrew+netdev, davem, edumazet, kuba, pabeni, nitsingh,
	netdev

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 26 May 2025 10:44:33 +0800 you wrote:
> We stop queues in ndo_stop, so they need to be restarted in ndo_open.
> This allows us to resume tx after a link down/up cycle.
> 
> Suggested-by: Nitin Singh <nitsingh@nvidia.com>
> Fixes: 0791c0327a6e ("net: mctp: Add MCTP USB transport driver")
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
> 
> [...]

Here is the summary with links:
  - [net] net: mctp: start tx queue on netdev open
    https://git.kernel.org/netdev/net/c/126cd7852a62

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-05-28  0:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-26  2:44 [PATCH net] net: mctp: start tx queue on netdev open Jeremy Kerr
2025-05-28  0:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).