From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp1.cs.Stanford.EDU (smtp1.cs.stanford.edu [171.64.64.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3657C1BCA07 for ; Mon, 26 May 2025 04:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=171.64.64.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748233755; cv=none; b=N6x/iPFrfNgCu2j4sZpjZP3D6QlvqsdvdOACO96CkQy+gNTh0bsRykHOZLrkw917ZoXcfhH4rS3Y0gRwYCwk8VgmZ5/F/ScSlJdUSho3iIjA+WgzgBncrwdY1OLUDQaKn48oH6ujZpi41j5rMCYHcKr7UhH8CAeGjasu+XEhdC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748233755; c=relaxed/simple; bh=32Ef//Q7GcPYnLu2GFpP+wIaPDfL1aPmOpWG0otAj/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PfPiuENH53fXhf5NcDengTea1W7HjXwKAWC/5lz92oeNkfccNoF9kED2xCZKbOWyAxxCKaDBUzAo6dMc+UY0wMMeNaR1suX7cDBSmWzPAwJnHSkjJqmqAw1QbtMrdv4/3B5tMzIj1iR2rkhm80Ji7R6MDLHkHzPJYcU0rLgXkV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cs.stanford.edu; spf=pass smtp.mailfrom=cs.stanford.edu; dkim=pass (2048-bit key) header.d=cs.stanford.edu header.i=@cs.stanford.edu header.b=YmBKPUwh; arc=none smtp.client-ip=171.64.64.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cs.stanford.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cs.stanford.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cs.stanford.edu header.i=@cs.stanford.edu header.b="YmBKPUwh" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cs.stanford.edu; s=cs2308; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uhObMIT9BY3LrrNxHJQrO1+DENmsYb74X+c7ifNKbLE=; t=1748233754; x=1749097754; b=YmBKPUwh/RoORAeuIWh68hg3yNxdDrXl2gx532ZZzBfpIoSkl4+SaWLpL35hStuiGQYdrt62oye Z1xwYOezUvQfRD2Mwh3suWQkC/Teoxy4ek7ersTcBoYnfBK3CUX1TTSAaE2FfkpmY/dsli39bsWp0 hq7nXB3Pj0tBcxkXcbMVJRfIl0Z8V+fsRfsSnsMqTwIX9HaACJhGpHrmceJCT8xLDhIEOMOwxoXwD 674DrY24qdLW7q+lw8qbIh+WCjlvXESQae/tVJQsGuhMcvPqRH7gNkbdYjmwcoEUM5Tbtz7l0fkji 8QTsH5OLGsG8ZGY/izvUAU+bizhd9nQn4lUA==; Received: from 70-228-78-207.lightspeed.sntcca.sbcglobal.net ([70.228.78.207]:54961 helo=localhost.localdomain) by smtp1.cs.Stanford.EDU with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uJPSb-0006Qy-6o; Sun, 25 May 2025 21:29:13 -0700 From: John Ousterhout To: netdev@vger.kernel.org Cc: pabeni@redhat.com, edumazet@google.com, horms@kernel.org, kuba@kernel.org, John Ousterhout Subject: [PATCH net-next v9 13/15] net: homa: create homa_timer.c Date: Sun, 25 May 2025 21:28:15 -0700 Message-ID: <20250526042819.2526-14-ouster@cs.stanford.edu> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20250526042819.2526-1-ouster@cs.stanford.edu> References: <20250526042819.2526-1-ouster@cs.stanford.edu> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.0 X-Spam-Level: X-Scan-Signature: c8456bbff965cedeafcda1d0f46e7a17 This file contains code that wakes up periodically to check for missing data, initiate retransmissions, and declare peer nodes "dead". Signed-off-by: John Ousterhout --- Changes for v9: * Reflect changes in socket and peer management * Minor name changes for clarity Changes for v7: * Interface changes to homa_sock_start_scan etc. * Remove locker argument from locking functions * Use u64 and __u64 properly --- net/homa/homa_impl.h | 3 + net/homa/homa_timer.c | 158 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 161 insertions(+) create mode 100644 net/homa/homa_timer.c diff --git a/net/homa/homa_impl.h b/net/homa/homa_impl.h index 4f9fd9997d28..b3243b4b3669 100644 --- a/net/homa/homa_impl.h +++ b/net/homa/homa_impl.h @@ -409,6 +409,9 @@ void homa_resend_pkt(struct sk_buff *skb, struct homa_rpc *rpc, struct homa_sock *hsk); void homa_rpc_handoff(struct homa_rpc *rpc); void homa_spin(int ns); +void homa_timer(struct homa *homa); +void homa_timer_check_rpc(struct homa_rpc *rpc); +int homa_timer_main(void *transport); struct sk_buff *homa_tx_data_pkt_alloc(struct homa_rpc *rpc, struct iov_iter *iter, int offset, int length, int max_seg_data); diff --git a/net/homa/homa_timer.c b/net/homa/homa_timer.c new file mode 100644 index 000000000000..e05dba14bc30 --- /dev/null +++ b/net/homa/homa_timer.c @@ -0,0 +1,158 @@ +// SPDX-License-Identifier: BSD-2-Clause + +/* This file handles timing-related functions for Homa, such as retries + * and timeouts. + */ + +#include "homa_impl.h" +#include "homa_peer.h" +#include "homa_rpc.h" +#include "homa_stub.h" + +/** + * homa_timer_check_rpc() - Invoked for each RPC during each timer pass; does + * most of the work of checking for time-related actions such as sending + * resends, aborting RPCs for which there is no response, and sending + * requests for acks. It is separate from homa_timer because homa_timer + * got too long and deeply indented. + * @rpc: RPC to check; must be locked by the caller. + */ +void homa_timer_check_rpc(struct homa_rpc *rpc) + __must_hold(&rpc->bucket->lock) +{ + struct homa *homa = rpc->hsk->homa; + struct homa_resend_hdr resend; + + /* See if we need to request an ack for this RPC. */ + if (!homa_is_client(rpc->id) && rpc->state == RPC_OUTGOING && + rpc->msgout.next_xmit_offset >= rpc->msgout.length) { + if (rpc->done_timer_ticks == 0) { + rpc->done_timer_ticks = homa->timer_ticks; + } else { + /* >= comparison that handles tick wrap-around. */ + if ((rpc->done_timer_ticks + homa->request_ack_ticks + - 1 - homa->timer_ticks) & 1 << 31) { + struct homa_need_ack_hdr h; + + homa_xmit_control(NEED_ACK, &h, sizeof(h), rpc); + } + } + } + + if (rpc->state == RPC_INCOMING) { + if (rpc->msgin.num_bpages == 0) { + /* Waiting for buffer space, so no problem. */ + rpc->silent_ticks = 0; + return; + } + } else if (!homa_is_client(rpc->id)) { + /* We're the server and we've received the input message; + * no need to worry about retries. + */ + rpc->silent_ticks = 0; + return; + } + + if (rpc->state == RPC_OUTGOING) { + if (rpc->msgout.next_xmit_offset < rpc->msgout.length) { + /* There are granted bytes that we haven't transmitted, + * so no need to be concerned; the ball is in our court. + */ + rpc->silent_ticks = 0; + return; + } + } + + if (rpc->silent_ticks < homa->resend_ticks) + return; + if (rpc->silent_ticks >= homa->timeout_ticks) { + homa_rpc_abort(rpc, -ETIMEDOUT); + return; + } + if (((rpc->silent_ticks - homa->resend_ticks) % homa->resend_interval) + != 0) + return; + + /* Issue a resend for the bytes just after the last ones received + * (gaps in the middle were already handled by homa_gap_retry above). + */ + if (rpc->msgin.length < 0) { + /* Haven't received any data for this message; request + * retransmission of just the first packet (the sender + * will send at least one full packet, regardless of + * the length below). + */ + resend.offset = htonl(0); + resend.length = htonl(100); + } else { + homa_gap_retry(rpc); + resend.offset = htonl(rpc->msgin.recv_end); + resend.length = htonl(rpc->msgin.length - rpc->msgin.recv_end); + if (resend.length == 0) + return; + } + homa_xmit_control(RESEND, &resend, sizeof(resend), rpc); +} + +/** + * homa_timer() - This function is invoked at regular intervals ("ticks") + * to implement retries and aborts for Homa. + * @homa: Overall data about the Homa protocol implementation. + */ +void homa_timer(struct homa *homa) +{ + struct homa_socktab_scan scan; + struct homa_sock *hsk; + struct homa_rpc *rpc; + int total_rpcs = 0; + int rpc_count = 0; + + homa->timer_ticks++; + + /* Scan all existing RPCs in all sockets. */ + for (hsk = homa_socktab_start_scan(homa->socktab, &scan); + hsk; hsk = homa_socktab_next(&scan)) { + while (hsk->dead_skbs >= homa->dead_buffs_limit) + /* If we get here, it means that Homa isn't keeping + * up with RPC reaping, so we'll help out. See + * "RPC Reaping Strategy" in homa_rpc_reap code for + * details. + */ + if (homa_rpc_reap(hsk, false) == 0) + break; + + if (list_empty(&hsk->active_rpcs) || hsk->shutdown) + continue; + + if (!homa_protect_rpcs(hsk)) + continue; + rcu_read_lock(); + list_for_each_entry_rcu(rpc, &hsk->active_rpcs, active_links) { + total_rpcs++; + homa_rpc_lock(rpc); + if (rpc->state == RPC_IN_SERVICE) { + rpc->silent_ticks = 0; + homa_rpc_unlock(rpc); + continue; + } + rpc->silent_ticks++; + homa_timer_check_rpc(rpc); + homa_rpc_unlock(rpc); + rpc_count++; + if (rpc_count >= 10) { + /* Give other kernel threads a chance to run + * on this core. + */ + rcu_read_unlock(); + schedule(); + rcu_read_lock(); + rpc_count = 0; + } + } + rcu_read_unlock(); + homa_unprotect_rpcs(hsk); + } + homa_socktab_end_scan(&scan); + homa_skb_release_pages(homa); + homa_peer_gc(homa->peertab); +} -- 2.43.0