From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3EAA270EAB; Tue, 27 May 2025 11:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748345640; cv=none; b=azhjJSMpqqomZTfy+b51UiYyKXGJZeP9YPSqA/FpuUodYtYUFJJD4DW7S8+Sts3WlTX3NdrgKA/9b+3pDleiwUC2oMCGN0R9TZWfaHNR8P0DLaVpqxRzZJtDxEllrRfhDTzm0GUHhHF2GG4Rowx3Uk7fqAaTX1oghm+NORahyOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748345640; c=relaxed/simple; bh=G4yxeje4skzZFbWd4GKautKhwMx5ZwXU4VPyyJVpR7k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=e9W1uxWY4NqKUz4ropzpQHhrEnu3vIzg/8+p0OP+KbRV6aWTAaUCqH06iXYHkSbWlLdQr5V09D0L0I/BdiBS8anRHzEsrZbXBvWv/lEbTxwfy8XTkqV4IOpgR+fL3Lny+pifaiyOlaTUAY+k2/tOty2DutH/vyy9J9fwtJ+vFnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Aw0iSSm1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Aw0iSSm1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7450C4CEE9; Tue, 27 May 2025 11:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748345639; bh=G4yxeje4skzZFbWd4GKautKhwMx5ZwXU4VPyyJVpR7k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Aw0iSSm1S0t3tCblVTk5XvM24Gwf7K/wfMLepIoY38//FCey7SfKwzIHcOFJG3PKz mvgsicZWYEJchF7QTR38ihY904D6I9JVfbLcOVVS6IWpDaJw6gn0O8rMPpQ/4jVEaX 5BdedD+R7OlPaUzFGpD31zcP9Deb8bpOh2sdNhVbomfktoD8Jkrw6mxmGspuBVlAbw 9rvDmCQ5i4P7cZvuM81UFSGn2VFTsSlPFxi4bmA2FuoorxoNc7brn0NGwiF5SnCNJa gCpFc9mZaJYBT44lnA6MHo4Mmmj1XboBvkhzUuMQd1ZA7RVAcu84PpgpIOlAXy46VF Wy/vvzZTETtpA== From: Jeff Layton Date: Tue, 27 May 2025 07:33:38 -0400 Subject: [PATCH v10 7/9] ref_tracker: add a way to create a symlink to the ref_tracker_dir debugfs file Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250527-reftrack-dbgfs-v10-7-dc55f7705691@kernel.org> References: <20250527-reftrack-dbgfs-v10-0-dc55f7705691@kernel.org> In-Reply-To: <20250527-reftrack-dbgfs-v10-0-dc55f7705691@kernel.org> To: Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin Cc: Kuniyuki Iwashima , Qasim Ijaz , Nathan Chancellor , Andrew Lunn , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3234; i=jlayton@kernel.org; h=from:subject:message-id; bh=G4yxeje4skzZFbWd4GKautKhwMx5ZwXU4VPyyJVpR7k=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBoNaMXBjdm+wdW+yNOSkgrF7FG2s7lNnUdusebv HDFwNef7JCJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaDWjFwAKCRAADmhBGVaC Fa4YD/9386ZVYoZVs5AQHOlKBk8PipdaE8wAGdwf8LprXtukpjpXE81e4Ffc6BqX5EKeib+wAjA XrNT4y8hcGNJRnsjv0VDofYhGPsuB9k+/A70ktsqWzPneIZ2k9UE2v26984NNUS/Q9h7zFPlMfB TZ641QJhGQss8zGnOO3XNF1ts0GpCRsUBTjfDPoAOVv+kG2wu/Tk0uW9oxH01ovdJ9ESy0m4aUh d4kZ5LLNeYh6EsZKZfzP7MTMbJpHgwbptKRTekvGc5goKxG1wosGdMv0CBzu4J9+bGfKEWKrOfj EkvCJIrUmLVGJvUiPVYiMgQLld1uf4bCB068PYM9uHOXSPOsoQ4J/XhvfQ4Z3I9RiysflJhZRNr hRyOG8XLiz74JCFZGC5xNEMrbi1PRlIp3viZbJnyGsWvVbVStDD9Ru9AA7oijBtrk6f2Y++cU+b 1eFecZTAWB8LdLHzbexk1aLoZPCI6lGuMrUY/XdU0RiZyiVuc1qGSDH1VYft6rt3ZBUaRimqNuT OVCS9yV6wR2LmryDteeooDfbXsrAPbdTNRI9/eTC+VXzKw6A0gxonbafwN6aHjNoEvYb1SMomMw Y+XB0xIkPWP7FcMjmLs7S4DkiYWZKsktTwyokH6cvOuhbwSN7Eacyi4gm/h+cTkH9P1ijH99Sv/ z9qjysyjvSD7Zmw== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Add the ability for a subsystem to add a user-friendly symlink that points to a ref_tracker_dir's debugfs file. Signed-off-by: Jeff Layton --- include/linux/ref_tracker.h | 13 +++++++++++++ lib/ref_tracker.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h index dd289fdda12b1a10197912f5796f97002e785aaf..ddc5a7b2bd84692bbc1e1ae67674ec2c6857e1ec 100644 --- a/include/linux/ref_tracker.h +++ b/include/linux/ref_tracker.h @@ -22,6 +22,7 @@ struct ref_tracker_dir { const char *class; /* object classname */ #ifdef CONFIG_DEBUG_FS struct dentry *dentry; + struct dentry *symlink; #endif char name[32]; #endif @@ -32,6 +33,7 @@ struct ref_tracker_dir { #ifdef CONFIG_DEBUG_FS void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir); +void ref_tracker_dir_symlink(struct ref_tracker_dir *dir, const char *fmt, ...); #else /* CONFIG_DEBUG_FS */ @@ -39,6 +41,11 @@ static inline void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir) { } +static inline __ostream_printf +void ref_tracker_dir_symlink(struct ref_tracker_dir *dir, const char *fmt, ...) +{ +} + #endif /* CONFIG_DEBUG_FS */ static inline void ref_tracker_dir_init(struct ref_tracker_dir *dir, @@ -56,6 +63,7 @@ static inline void ref_tracker_dir_init(struct ref_tracker_dir *dir, dir->class = class; #ifdef CONFIG_DEBUG_FS dir->dentry = NULL; + dir->symlink = NULL; #endif strscpy(dir->name, name, sizeof(dir->name)); ref_tracker_dir_debugfs(dir); @@ -91,6 +99,11 @@ static inline void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir) { } +static inline __ostream_printf +void ref_tracker_dir_symlink(struct ref_tracker_dir *dir, const char *fmt, ...) +{ +} + static inline void ref_tracker_dir_exit(struct ref_tracker_dir *dir) { } diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c index 1df12625d80cc7cff65d9f6be89e1dd5c5ffb7f6..5e84e5fd78e147a036d4adb511e657da07866a55 100644 --- a/lib/ref_tracker.c +++ b/lib/ref_tracker.c @@ -390,8 +390,36 @@ void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir) } EXPORT_SYMBOL(ref_tracker_dir_debugfs); +void __ostream_printf ref_tracker_dir_symlink(struct ref_tracker_dir *dir, const char *fmt, ...) +{ + char name[NAME_MAX + 1]; + va_list args; + int ret; + + /* Already created, or dentry doesn't exist? Do nothing */ + if (!IS_ERR_OR_NULL(dir->symlink) || IS_ERR_OR_NULL(dir->dentry)) + return; + + va_start(args, fmt); + ret = vsnprintf(name, sizeof(name), fmt, args); + va_end(args); + name[sizeof(name) - 1] = '\0'; + + if (ret < sizeof(name)) + dir->symlink = debugfs_create_symlink(name, ref_tracker_debug_dir, + dir->dentry->d_name.name); + else + dir->symlink = ERR_PTR(-ENAMETOOLONG); + + if (IS_ERR(dir->symlink)) + pr_warn("ref_tracker: unable to create debugfs symlink for %s: %pe\n", + name, dir->symlink); +} +EXPORT_SYMBOL(ref_tracker_dir_symlink); + static void ref_tracker_debugfs_remove(struct ref_tracker_dir *dir) { + debugfs_remove(dir->symlink); debugfs_remove(dir->dentry); } -- 2.49.0