* [net PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro
@ 2025-05-26 15:43 Subbaraya Sundeep
2025-05-27 1:22 ` kernel test robot
2025-05-27 6:46 ` kernel test robot
0 siblings, 2 replies; 3+ messages in thread
From: Subbaraya Sundeep @ 2025-05-26 15:43 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni, horms, saikrishnag,
gakula, hkelam, sgoutham, lcherian, bbhushan2, jerinj
Cc: netdev, Subbaraya Sundeep
Just because otx2_atomic64_add is using u64 pointer as argument
all callers has to typecast __iomem void pointers which inturn
causing sparse warnings. Fix those by changing otx2_atomic64_add
argument to void pointer.
Fixes: caa2da34fd25 ("octeontx2-pf: Initialize and config queues")
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
---
.../net/ethernet/marvell/octeontx2/nic/otx2_common.c | 17 +++++++++--------
.../net/ethernet/marvell/octeontx2/nic/otx2_common.h | 5 +++--
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 4 ++--
drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c | 5 +++--
4 files changed, 17 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index 84cd029..e5be021 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -28,12 +28,12 @@ static void otx2_nix_rq_op_stats(struct queue_stats *stats,
struct otx2_nic *pfvf, int qidx)
{
u64 incr = (u64)qidx << 32;
- u64 *ptr;
+ void __iomem *ptr;
- ptr = (u64 *)otx2_get_regaddr(pfvf, NIX_LF_RQ_OP_OCTS);
+ ptr = otx2_get_regaddr(pfvf, NIX_LF_RQ_OP_OCTS);
stats->bytes = otx2_atomic64_add(incr, ptr);
- ptr = (u64 *)otx2_get_regaddr(pfvf, NIX_LF_RQ_OP_PKTS);
+ ptr = otx2_get_regaddr(pfvf, NIX_LF_RQ_OP_PKTS);
stats->pkts = otx2_atomic64_add(incr, ptr);
}
@@ -41,12 +41,12 @@ static void otx2_nix_sq_op_stats(struct queue_stats *stats,
struct otx2_nic *pfvf, int qidx)
{
u64 incr = (u64)qidx << 32;
- u64 *ptr;
+ void __iomem *ptr;
- ptr = (u64 *)otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_OCTS);
+ ptr = otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_OCTS);
stats->bytes = otx2_atomic64_add(incr, ptr);
- ptr = (u64 *)otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_PKTS);
+ ptr = otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_PKTS);
stats->pkts = otx2_atomic64_add(incr, ptr);
}
@@ -860,9 +860,10 @@ void otx2_sqb_flush(struct otx2_nic *pfvf)
{
int qidx, sqe_tail, sqe_head;
struct otx2_snd_queue *sq;
- u64 incr, *ptr, val;
+ void __iomem *ptr;
+ u64 incr, val;
- ptr = (u64 *)otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_STATUS);
+ ptr = otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_STATUS);
for (qidx = 0; qidx < otx2_get_total_tx_queues(pfvf); qidx++) {
sq = &pfvf->qset.sq[qidx];
if (!sq->sqb_ptrs)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
index d6b4b74..c74e06e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
@@ -733,8 +733,9 @@ static inline void otx2_write128(u64 lo, u64 hi, void __iomem *addr)
::[x0]"r"(lo), [x1]"r"(hi), [p1]"r"(addr));
}
-static inline u64 otx2_atomic64_add(u64 incr, u64 *ptr)
+static inline u64 otx2_atomic64_add(u64 incr, void __iomem *addr)
{
+ u64 __iomem *ptr = addr;
u64 result;
__asm__ volatile(".cpu generic+lse\n"
@@ -797,7 +798,7 @@ static inline void cn10k_aura_freeptr(void *dev, int aura, u64 buf)
/* Alloc pointer from pool/aura */
static inline u64 otx2_aura_allocptr(struct otx2_nic *pfvf, int aura)
{
- u64 *ptr = (__force u64 *)otx2_get_regaddr(pfvf, NPA_LF_AURA_OP_ALLOCX(0));
+ void __iomem *ptr = otx2_get_regaddr(pfvf, NPA_LF_AURA_OP_ALLOCX(0));
u64 incr = (u64)aura | BIT_ULL(63);
return otx2_atomic64_add(incr, ptr);
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
index cfed9ec..b303a03 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
@@ -1305,8 +1305,8 @@ static irqreturn_t otx2_q_intr_handler(int irq, void *data)
{
struct otx2_nic *pf = data;
struct otx2_snd_queue *sq;
- u64 val, *ptr;
- u64 qidx = 0;
+ void __iomem *ptr;
+ u64 val, qidx = 0;
/* CQ */
for (qidx = 0; qidx < pf->qset.cq_cnt; qidx++) {
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c b/drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c
index c5dbae0..d3ae390 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c
@@ -151,9 +151,10 @@ static void otx2_qos_sq_free_sqbs(struct otx2_nic *pfvf, int qidx)
static void otx2_qos_sqb_flush(struct otx2_nic *pfvf, int qidx)
{
int sqe_tail, sqe_head;
- u64 incr, *ptr, val;
+ void __iomem *ptr;
+ u64 incr, val;
- ptr = (__force u64 *)otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_STATUS);
+ ptr = otx2_get_regaddr(pfvf, NIX_LF_SQ_OP_STATUS);
incr = (u64)qidx << 32;
val = otx2_atomic64_add(incr, ptr);
sqe_head = (val >> 20) & 0x3F;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro
2025-05-26 15:43 [net PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro Subbaraya Sundeep
@ 2025-05-27 1:22 ` kernel test robot
2025-05-27 6:46 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-05-27 1:22 UTC (permalink / raw)
To: Subbaraya Sundeep, andrew+netdev, davem, edumazet, kuba, pabeni,
horms, saikrishnag, gakula, hkelam, sgoutham, lcherian, bbhushan2,
jerinj
Cc: llvm, oe-kbuild-all, netdev, Subbaraya Sundeep
Hi Subbaraya,
kernel test robot noticed the following build errors:
[auto build test ERROR on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Subbaraya-Sundeep/octeontx2-pf-Avoid-typecasts-by-simplifying-otx2_atomic64_add-macro/20250526-234505
base: net/main
patch link: https://lore.kernel.org/r/1748274232-20835-1-git-send-email-sbhatta%40marvell.com
patch subject: [net PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro
config: x86_64-buildonly-randconfig-006-20250527 (https://download.01.org/0day-ci/archive/20250527/202505270941.xkydqqTv-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250527/202505270941.xkydqqTv-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505270941.xkydqqTv-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c:10:
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
804 | return otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c:451:14: warning: shift count >= width of type [-Wshift-count-overflow]
451 | cc->mask = CYCLECOUNTER_MASK(64);
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/timecounter.h:14:59: note: expanded from macro 'CYCLECOUNTER_MASK'
14 | #define CYCLECOUNTER_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
| ^ ~~~~~~
2 warnings and 1 error generated.
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c:13:
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
804 | return otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
1 warning and 1 error generated.
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:17:
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
804 | return otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:34:17: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
34 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:34:17: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
34 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:37:16: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
37 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:37:16: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
37 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:47:17: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
47 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:47:17: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
47 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:50:16: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
50 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:50:16: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
50 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:873:9: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
873 | val = otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:873:9: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
873 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
6 warnings and 6 errors generated.
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:11:
In file included from drivers/net/ethernet/marvell/octeontx2/nic/cn10k.h:11:
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
804 | return otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:159:8: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
159 | val = otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:159:8: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
159 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
2 warnings and 2 errors generated.
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:22:
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
804 | return otx2_atomic64_add(incr, ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:9: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1314:9: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
1314 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1314:9: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
1314 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1353:9: warning: ISO C does not allow indirection on operand of type 'void *' [-Wvoid-ptr-dereference]
1353 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^ ~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:42: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1353:9: error: invalid operands to binary expression ('void' and 'u64' (aka 'unsigned long long'))
1353 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:47: note: expanded from macro 'otx2_atomic64_add'
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ~~~~ ^ ~~~~
3 warnings and 3 errors generated.
vim +804 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
4c236d5dc8b8622 Geetha sowjanya 2021-02-11 797
caa2da34fd25a37 Sunil Goutham 2020-01-27 798 /* Alloc pointer from pool/aura */
caa2da34fd25a37 Sunil Goutham 2020-01-27 799 static inline u64 otx2_aura_allocptr(struct otx2_nic *pfvf, int aura)
caa2da34fd25a37 Sunil Goutham 2020-01-27 800 {
22f5790bc6ba331 Subbaraya Sundeep 2025-05-26 801 void __iomem *ptr = otx2_get_regaddr(pfvf, NPA_LF_AURA_OP_ALLOCX(0));
caa2da34fd25a37 Sunil Goutham 2020-01-27 802 u64 incr = (u64)aura | BIT_ULL(63);
caa2da34fd25a37 Sunil Goutham 2020-01-27 803
caa2da34fd25a37 Sunil Goutham 2020-01-27 @804 return otx2_atomic64_add(incr, ptr);
caa2da34fd25a37 Sunil Goutham 2020-01-27 805 }
caa2da34fd25a37 Sunil Goutham 2020-01-27 806
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro
2025-05-26 15:43 [net PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro Subbaraya Sundeep
2025-05-27 1:22 ` kernel test robot
@ 2025-05-27 6:46 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-05-27 6:46 UTC (permalink / raw)
To: Subbaraya Sundeep, andrew+netdev, davem, edumazet, kuba, pabeni,
horms, saikrishnag, gakula, hkelam, sgoutham, lcherian, bbhushan2,
jerinj
Cc: oe-kbuild-all, netdev, Subbaraya Sundeep
Hi Subbaraya,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Subbaraya-Sundeep/octeontx2-pf-Avoid-typecasts-by-simplifying-otx2_atomic64_add-macro/20250526-234505
base: net/main
patch link: https://lore.kernel.org/r/1748274232-20835-1-git-send-email-sbhatta%40marvell.com
patch subject: [net PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20250527/202505271459.ZZab1GQF-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250527/202505271459.ZZab1GQF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505271459.ZZab1GQF-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:22:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c: In function 'otx2_q_intr_handler':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1314:23: note: in expansion of macro 'otx2_atomic64_add'
1314 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1314:23: note: in expansion of macro 'otx2_atomic64_add'
1314 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1353:23: note: in expansion of macro 'otx2_atomic64_add'
1353 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:1353:23: note: in expansion of macro 'otx2_atomic64_add'
1353 | val = otx2_atomic64_add((qidx << 44), ptr);
| ^~~~~~~~~~~~~~~~~
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:17:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c: In function 'otx2_nix_rq_op_stats':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:34:24: note: in expansion of macro 'otx2_atomic64_add'
34 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:34:24: note: in expansion of macro 'otx2_atomic64_add'
34 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:37:23: note: in expansion of macro 'otx2_atomic64_add'
37 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:37:23: note: in expansion of macro 'otx2_atomic64_add'
37 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c: In function 'otx2_nix_sq_op_stats':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:47:24: note: in expansion of macro 'otx2_atomic64_add'
47 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:47:24: note: in expansion of macro 'otx2_atomic64_add'
47 | stats->bytes = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:50:23: note: in expansion of macro 'otx2_atomic64_add'
50 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:50:23: note: in expansion of macro 'otx2_atomic64_add'
50 | stats->pkts = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c: In function 'otx2_sqb_flush':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:873:23: note: in expansion of macro 'otx2_atomic64_add'
873 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c:873:23: note: in expansion of macro 'otx2_atomic64_add'
873 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:805:1: warning: control reaches end of non-void function [-Wreturn-type]
805 | }
| ^
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c:18:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/cn10k.h:11,
from drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:11:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c: In function 'otx2_qos_sqb_flush':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:159:15: note: in expansion of macro 'otx2_atomic64_add'
159 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c:159:15: note: in expansion of macro 'otx2_atomic64_add'
159 | val = otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:805:1: warning: control reaches end of non-void function [-Wreturn-type]
805 | }
| ^
--
In file included from drivers/net/ethernet/marvell/octeontx2/nic/otx2_xsk.c:13:
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h: In function 'otx2_aura_allocptr':
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:52: warning: dereferencing 'void *' pointer
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:751:57: error: invalid use of void expression
751 | #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
| ^~
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:804:16: note: in expansion of macro 'otx2_atomic64_add'
804 | return otx2_atomic64_add(incr, ptr);
| ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h:805:1: warning: control reaches end of non-void function [-Wreturn-type]
805 | }
| ^
vim +751 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
caa2da34fd25a3 Sunil Goutham 2020-01-27 748
caa2da34fd25a3 Sunil Goutham 2020-01-27 749 #else
4c236d5dc8b862 Geetha sowjanya 2021-02-11 750 #define otx2_write128(lo, hi, addr) writeq((hi) | (lo), addr)
caa2da34fd25a3 Sunil Goutham 2020-01-27 @751 #define otx2_atomic64_add(incr, ptr) ({ *ptr += incr; })
caa2da34fd25a3 Sunil Goutham 2020-01-27 752 #endif
caa2da34fd25a3 Sunil Goutham 2020-01-27 753
4c236d5dc8b862 Geetha sowjanya 2021-02-11 754 static inline void __cn10k_aura_freeptr(struct otx2_nic *pfvf, u64 aura,
ef6c8da71eaffe Geetha sowjanya 2021-09-01 755 u64 *ptrs, u64 num_ptrs)
4c236d5dc8b862 Geetha sowjanya 2021-02-11 756 {
ef6c8da71eaffe Geetha sowjanya 2021-09-01 757 struct otx2_lmt_info *lmt_info;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 758 u64 size = 0, count_eot = 0;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 759 u64 tar_addr, val = 0;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 760
ef6c8da71eaffe Geetha sowjanya 2021-09-01 761 lmt_info = per_cpu_ptr(pfvf->hw.lmt_info, smp_processor_id());
4c236d5dc8b862 Geetha sowjanya 2021-02-11 762 tar_addr = (__force u64)otx2_get_regaddr(pfvf, NPA_LF_AURA_BATCH_FREE0);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 763 /* LMTID is same as AURA Id */
ef6c8da71eaffe Geetha sowjanya 2021-09-01 764 val = (lmt_info->lmt_id & 0x7FF) | BIT_ULL(63);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 765 /* Set if [127:64] of last 128bit word has a valid pointer */
4c236d5dc8b862 Geetha sowjanya 2021-02-11 766 count_eot = (num_ptrs % 2) ? 0ULL : 1ULL;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 767 /* Set AURA ID to free pointer */
4c236d5dc8b862 Geetha sowjanya 2021-02-11 768 ptrs[0] = (count_eot << 32) | (aura & 0xFFFFF);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 769 /* Target address for LMTST flush tells HW how many 128bit
4c236d5dc8b862 Geetha sowjanya 2021-02-11 770 * words are valid from NPA_LF_AURA_BATCH_FREE0.
4c236d5dc8b862 Geetha sowjanya 2021-02-11 771 *
4c236d5dc8b862 Geetha sowjanya 2021-02-11 772 * tar_addr[6:4] is LMTST size-1 in units of 128b.
4c236d5dc8b862 Geetha sowjanya 2021-02-11 773 */
4c236d5dc8b862 Geetha sowjanya 2021-02-11 774 if (num_ptrs > 2) {
4c236d5dc8b862 Geetha sowjanya 2021-02-11 775 size = (sizeof(u64) * num_ptrs) / 16;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 776 if (!count_eot)
4c236d5dc8b862 Geetha sowjanya 2021-02-11 777 size++;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 778 tar_addr |= ((size - 1) & 0x7) << 4;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 779 }
c5d731c54a1767 Geetha sowjanya 2022-01-21 780 dma_wmb();
ef6c8da71eaffe Geetha sowjanya 2021-09-01 781 memcpy((u64 *)lmt_info->lmt_addr, ptrs, sizeof(u64) * num_ptrs);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 782 /* Perform LMTST flush */
4c236d5dc8b862 Geetha sowjanya 2021-02-11 783 cn10k_lmt_flush(val, tar_addr);
4c236d5dc8b862 Geetha sowjanya 2021-02-11 784 }
4c236d5dc8b862 Geetha sowjanya 2021-02-11 785
4c236d5dc8b862 Geetha sowjanya 2021-02-11 786 static inline void cn10k_aura_freeptr(void *dev, int aura, u64 buf)
4c236d5dc8b862 Geetha sowjanya 2021-02-11 787 {
4c236d5dc8b862 Geetha sowjanya 2021-02-11 788 struct otx2_nic *pfvf = dev;
4c236d5dc8b862 Geetha sowjanya 2021-02-11 789 u64 ptrs[2];
4c236d5dc8b862 Geetha sowjanya 2021-02-11 790
4c236d5dc8b862 Geetha sowjanya 2021-02-11 791 ptrs[1] = buf;
55ba18dc62deff Kevin Hao 2023-01-18 792 get_cpu();
ef6c8da71eaffe Geetha sowjanya 2021-09-01 793 /* Free only one buffer at time during init and teardown */
ef6c8da71eaffe Geetha sowjanya 2021-09-01 794 __cn10k_aura_freeptr(pfvf, aura, ptrs, 2);
55ba18dc62deff Kevin Hao 2023-01-18 795 put_cpu();
4c236d5dc8b862 Geetha sowjanya 2021-02-11 796 }
4c236d5dc8b862 Geetha sowjanya 2021-02-11 797
caa2da34fd25a3 Sunil Goutham 2020-01-27 798 /* Alloc pointer from pool/aura */
caa2da34fd25a3 Sunil Goutham 2020-01-27 799 static inline u64 otx2_aura_allocptr(struct otx2_nic *pfvf, int aura)
caa2da34fd25a3 Sunil Goutham 2020-01-27 800 {
22f5790bc6ba33 Subbaraya Sundeep 2025-05-26 801 void __iomem *ptr = otx2_get_regaddr(pfvf, NPA_LF_AURA_OP_ALLOCX(0));
caa2da34fd25a3 Sunil Goutham 2020-01-27 802 u64 incr = (u64)aura | BIT_ULL(63);
caa2da34fd25a3 Sunil Goutham 2020-01-27 803
caa2da34fd25a3 Sunil Goutham 2020-01-27 @804 return otx2_atomic64_add(incr, ptr);
caa2da34fd25a3 Sunil Goutham 2020-01-27 @805 }
caa2da34fd25a3 Sunil Goutham 2020-01-27 806
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-27 6:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-26 15:43 [net PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro Subbaraya Sundeep
2025-05-27 1:22 ` kernel test robot
2025-05-27 6:46 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).