From: Simon Horman <horms@kernel.org>
To: Subbaraya Sundeep <sbhatta@marvell.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, saikrishnag@marvell.com,
gakula@marvell.com, hkelam@marvell.com, sgoutham@marvell.com,
lcherian@marvell.com, bbhushan2@marvell.com, jerinj@marvell.com,
netdev@vger.kernel.org
Subject: Re: [net v2 PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro
Date: Wed, 28 May 2025 13:55:01 +0100 [thread overview]
Message-ID: <20250528125501.GC365796@horms.kernel.org> (raw)
In-Reply-To: <1748340180-32124-1-git-send-email-sbhatta@marvell.com>
On Tue, May 27, 2025 at 03:33:00PM +0530, Subbaraya Sundeep wrote:
> Just because otx2_atomic64_add is using u64 pointer as argument
> all callers has to typecast __iomem void pointers which inturn
> causing sparse warnings. Fix those by changing otx2_atomic64_add
> argument to void pointer.
I'm wondering if you considered changing the type of the 2nd parameter
of otx2_atomic64_add to u64 __iomem * and, correspondingly, the type
of the local variables updated by this patch. Perhaps that isn't so
clean for some reason. But if it can be done cleanly it does seem slightly
nicer to me.
>
> Fixes: caa2da34fd25 ("octeontx2-pf: Initialize and config queues")
I do appreciate this change. But I wonder if it is more of a
clean-up for net-next (once it re-opens, no Fixes tag) than
a fix.
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> ---
> v2:
> Fixed x86 build error of void pointer dereference reported by
> kernel test robot
...
prev parent reply other threads:[~2025-05-28 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 10:03 [net v2 PATCH] octeontx2-pf: Avoid typecasts by simplifying otx2_atomic64_add macro Subbaraya Sundeep
2025-05-28 12:55 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528125501.GC365796@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saikrishnag@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).