From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
<maciej.fijalkowski@intel.com>, <magnus.karlsson@intel.com>,
<michal.kubiak@intel.com>, <przemyslaw.kitszel@intel.com>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <horms@kernel.org>,
<bpf@vger.kernel.org>
Subject: Re: [PATCH net-next 03/16] libeth: xdp: add XDP_TX buffers sending
Date: Wed, 28 May 2025 17:18:30 -0700 [thread overview]
Message-ID: <20250528171830.5968d18d@kernel.org> (raw)
In-Reply-To: <28b075ea-4126-4885-92a6-4633d4573f85@intel.com>
On Wed, 28 May 2025 16:57:15 +0200 Alexander Lobakin wrote:
> > On Tue, 20 May 2025 13:59:04 -0700 Tony Nguyen wrote:
> >> + if (sinfo || !netmem_is_net_iov(netmem)) {
> >> + const struct page_pool *pp = __netmem_get_pp(netmem);
> >> +
> >> + dma_sync_single_for_device(pp->p.dev, desc.addr, desc.len,
> >> + DMA_BIDIRECTIONAL);
> >> + }
> >
> > How can we get an unreadable netmem into the XDP Tx path?
>
> For now, it's not allowed. This is future proof. I have plans to allow
> XDP and devmem to co-exist when the XDP program doesn't want to access
> frags, only headers. In that case, why forbid?
Nonsensical code is harder to maintain. Someone may need to refactor
this later and waste time trying to figure out why the condition is
there.
Plus in patch 1 you remove legit conditions to save branches and here
you seem to happily sprinkle dead code.
next prev parent reply other threads:[~2025-05-29 0:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 20:59 [PATCH net-next 00/16][pull request] libeth: add libeth_xdp helper lib Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 01/16] libeth: convert to netmem Tony Nguyen
2025-05-28 1:57 ` Jakub Kicinski
2025-05-28 3:49 ` Mina Almasry
2025-05-29 0:23 ` Jakub Kicinski
2025-05-28 14:54 ` Alexander Lobakin
2025-05-29 0:25 ` Jakub Kicinski
2025-05-20 20:59 ` [PATCH net-next 02/16] libeth: support native XDP and register memory model Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 03/16] libeth: xdp: add XDP_TX buffers sending Tony Nguyen
2025-05-28 2:03 ` Jakub Kicinski
2025-05-28 14:57 ` Alexander Lobakin
2025-05-29 0:18 ` Jakub Kicinski [this message]
2025-05-20 20:59 ` [PATCH net-next 04/16] libeth: xdp: add .ndo_xdp_xmit() helpers Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 05/16] libeth: xdp: add XDPSQE completion helpers Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 06/16] libeth: xdp: add XDPSQ locking helpers Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 07/16] libeth: xdp: add XDPSQ cleanup timers Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 08/16] libeth: xdp: add helpers for preparing/processing &libeth_xdp_buff Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 09/16] libeth: xdp: add XDP prog run and verdict result handling Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 10/16] libeth: xdp: add templates for building driver-side callbacks Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 11/16] libeth: xdp: add RSS hash hint and XDP features setup helpers Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 12/16] libeth: xsk: add XSk XDP_TX sending helpers Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 13/16] libeth: xsk: add XSk xmit functions Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 14/16] libeth: xsk: add XSk Rx processing support Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 15/16] libeth: xsk: add XSkFQ refill and XSk wakeup helpers Tony Nguyen
2025-05-20 20:59 ` [PATCH net-next 16/16] libeth: xdp, xsk: access adjacent u32s as u64 where applicable Tony Nguyen
2025-05-27 13:49 ` [PATCH net-next 00/16][pull request] libeth: add libeth_xdp helper lib Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528171830.5968d18d@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).