Re: [PATCH net] selftests: net: build net/lib dependency in all target

[Simon Horman <horms@kernel.org>]

On Thu, May 29, 2025 at 06:04:17PM +0700, Bui Quang Minh wrote:
> On 5/29/25 17:32, Simon Horman wrote:
> > On Thu, May 29, 2025 at 02:05:36PM +0700, Bui Quang Minh wrote:
> > > Currently, we only build net/lib dependency in install target. This
> > > commit moves that to all target so that net/lib is included in in-tree
> > > build and run_tests.
> > Hi,
> > 
> > The above describes what is being done.
> > I think it would be good to also describe why.
> 
> Hi,
> 
> Currently, when building net related selftests, we need to
> 
>     make install
> 
> so that the net/lib is compiled. In case we do
> 
>     make
> 
> or
> 
>     make run_tests
> 
> the net/lib is not compiled. So I move the INSTALL_DEP_TARGETS which is
> net/lib if the selftests is net related to all. As a result, all make/make
> install/make run_tests will have the net/lib compiled.

Thanks for the explanation, it is much appreciated.

I think it would be good to include something along those lines
in the commit message of the patch.

Please note, that if you post a v2, before doing so you should allow 24h to
elapse since the posting of v1.

https://docs.kernel.org/process/maintainer-netdev.html