From: Simon Horman <horms@kernel.org>
To: Li Jun <lijun01@kylinos.cn>
Cc: davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ppp: remove error variable
Date: Fri, 30 May 2025 19:17:30 +0100 [thread overview]
Message-ID: <20250530181730.GU1484967@horms.kernel.org> (raw)
In-Reply-To: <20250530025040.379064-1-lijun01@kylinos.cn>
On Fri, May 30, 2025 at 10:50:40AM +0800, Li Jun wrote:
> the error variable did not function as a variable.
> so remove it.
>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
Hi Li Jun,
Overall your patch looks good to me but as a cleanup for Networking
code it would be best to explicitly target net-next like this:
Subject: [PATCH net-next] ...
But more importantly, net-next is currently closed, so please
repost your patch once it re-opens.
For reference, information on the development process can be found here.
https://docs.kernel.org/process/maintainer-netdev.html
## Form letter - net-next-closed
The merge window for v6.16 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations. We are
currently accepting bug fixes only.
Please repost when net-next reopens after June 8th.
RFC patches sent for review only are obviously welcome at any time.
--
pw-bot: defer
next prev parent reply other threads:[~2025-05-30 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 2:50 [PATCH] net: ppp: remove error variable Li Jun
2025-05-30 18:17 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-30 2:48 Li Jun
2025-05-30 5:40 ` Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250530181730.GU1484967@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=lijun01@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).