From: Jakub Kicinski <kuba@kernel.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: danieller@nvidia.com, idosch@idosch.org, netdev@vger.kernel.org
Subject: Re: [PATCH ethtool 0/2] module_common: adjust the JSON output for per-lane signals
Date: Fri, 30 May 2025 18:20:02 -0700 [thread overview]
Message-ID: <20250530182002.557c8256@kernel.org> (raw)
In-Reply-To: <tby3ld5penbfzrpvlbocwrmnyyahtjrocejelqfhfcrryz3uzq@24fixhzgipcl>
On Fri, 30 May 2025 13:35:25 +0200 Michal Kubecek wrote:
> On Thu, May 29, 2025 at 07:20:31AM GMT, Jakub Kicinski wrote:
> > I got some feedback from users trying to integrate the SFP JSON
> > output to Meta's monitoring systems. The loss / fault signals
> > are currently a bit awkward to parse. This patch set changes
> > the format, is it still okay to merge it (as a fix?)
> > I think it's a worthwhile improvement, not sure how many people
> > depend on the current JSON format after 1 release..
>
> It's unfortunate that the format already got into 6.14 but thankfully
> it's been only about six weeks since so hopefully there won't be many
> (or perhaps none if we are lucky).
>
> I wonder if it would make sense to also release 6.14.1 with the format
> change to make it more apparent for those using 6.14 that the change
> should be backported. SLE16 (and Leap 16.0) is going to be one of the
> distributions with ethtool 6.14 but there I can add the patch myself.
FWIW I'll try to get it backported to Fedora / CentOS too.
So cutting 6.14.1 may be preferable.
next prev parent reply other threads:[~2025-05-31 1:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 14:20 [PATCH ethtool 0/2] module_common: adjust the JSON output for per-lane signals Jakub Kicinski
2025-05-29 14:20 ` [PATCH ethtool 1/2] module_common: always print per-lane status in JSON Jakub Kicinski
2025-05-29 15:53 ` Ido Schimmel
2025-05-29 14:20 ` [PATCH ethtool 2/2] module_common: print loss / fault signals as bool Jakub Kicinski
2025-05-29 15:53 ` Ido Schimmel
2025-05-29 23:02 ` [PATCH ethtool 0/2] module_common: adjust the JSON output for per-lane signals Joe Damato
2025-05-30 11:35 ` Michal Kubecek
2025-05-31 1:20 ` Jakub Kicinski [this message]
2025-06-10 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250530182002.557c8256@kernel.org \
--to=kuba@kernel.org \
--cc=danieller@nvidia.com \
--cc=idosch@idosch.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).