From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
willemb@google.com, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: drv-net: add configs for the TSO test
Date: Tue, 3 Jun 2025 06:55:37 -0700 [thread overview]
Message-ID: <20250603065537.718be88c@kernel.org> (raw)
In-Reply-To: <bc91b431-9cb5-400a-afee-f5cbfda11788@redhat.com>
On Tue, 3 Jun 2025 13:17:25 +0200 Paolo Abeni wrote:
> On 6/3/25 1:16 AM, Jakub Kicinski wrote:
> > diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config
> > new file mode 100644
> > index 000000000000..ea4b70d71563
> > --- /dev/null
> > +++ b/tools/testing/selftests/drivers/net/hw/config
> > @@ -0,0 +1,6 @@
> > +CONFIG_IPV6=y
> > +CONFIG_IPV6_GRE=y
> > +CONFIG_NET_IP_TUNNEL=y
>
> I think the above it's not strictly needed, because it's selected by gre
> and vxlan (indirectly), but it should not hurt, nor I think we have
> minimal non redundant knobs list in other config files.
Oops, you're right. I'll respin after
netlink: specs: rt-link: decode ip6gre
gets thru CI, this change alone fixed TSO but broke the stats test :S
prev parent reply other threads:[~2025-06-03 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 23:16 [PATCH net] selftests: drv-net: add configs for the TSO test Jakub Kicinski
2025-06-03 11:17 ` Paolo Abeni
2025-06-03 13:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250603065537.718be88c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).