From: Simon Horman <horms@kernel.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: almasrymina@google.com, bcf@google.com, joshwash@google.com,
willemb@google.com, pkaligineedi@google.com, pabeni@redhat.com,
kuba@kernel.org, jeroendb@google.com, hramamurthy@google.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
darren.kenny@oracle.com
Subject: Re: [PATCH net v2] gve: add missing NULL check for gve_alloc_pending_packet() in TX DQO
Date: Tue, 3 Jun 2025 09:25:06 +0100 [thread overview]
Message-ID: <20250603082506.GZ1484967@horms.kernel.org> (raw)
In-Reply-To: <20250602103450.3472509-1-alok.a.tiwari@oracle.com>
On Mon, Jun 02, 2025 at 03:34:29AM -0700, Alok Tiwari wrote:
> gve_alloc_pending_packet() can return NULL, but gve_tx_add_skb_dqo()
> did not check for this case before dereferencing the returned pointer.
>
> Add a missing NULL check to prevent a potential NULL pointer
> dereference when allocation fails.
>
> This improves robustness in low-memory scenarios.
>
> Fixes: a57e5de476be ("gve: DQO: Add TX path")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> Reviewed-by: Mina Almasry <almasrymina@google.com>
> ---
> v1->v2
> added Fixes tag and [PATCH net v2]
This patch is marked as Rejected in patchwork, but it's unclear to me why.
The patch does look good to me, there was positive review to v1 which
is addressed in v2, and i see no prior comment on v2. I'm updating it's
status accordingly. Apologies if I missed something.
Reviewed-by: Simon Horman <horms@kernel.org>
--
pw-bot: under-review
next prev parent reply other threads:[~2025-06-03 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 10:34 [PATCH net v2] gve: add missing NULL check for gve_alloc_pending_packet() in TX DQO Alok Tiwari
2025-06-03 8:25 ` Simon Horman [this message]
2025-06-04 11:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250603082506.GZ1484967@horms.kernel.org \
--to=horms@kernel.org \
--cc=almasrymina@google.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcf@google.com \
--cc=darren.kenny@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).