[PATCH net v2] gve: add missing NULL check for gve_alloc_pending_packet() in TX DQO

[PATCH net v2] gve: add missing NULL check for gve_alloc_pending_packet() in TX DQO

[Alok Tiwari]

gve_alloc_pending_packet() can return NULL, but gve_tx_add_skb_dqo()
did not check for this case before dereferencing the returned pointer.

Add a missing NULL check to prevent a potential NULL pointer
dereference when allocation fails.

This improves robustness in low-memory scenarios.

Fixes: a57e5de476be ("gve: DQO: Add TX path")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Mina Almasry <almasrymina@google.com>
---
v1->v2
added Fixes tag and [PATCH net v2]
---
 drivers/net/ethernet/google/gve/gve_tx_dqo.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/google/gve/gve_tx_dqo.c b/drivers/net/ethernet/google/gve/gve_tx_dqo.c
index a27f1574a733..9d705d94b065 100644
--- a/drivers/net/ethernet/google/gve/gve_tx_dqo.c
+++ b/drivers/net/ethernet/google/gve/gve_tx_dqo.c
@@ -764,6 +764,9 @@ static int gve_tx_add_skb_dqo(struct gve_tx_ring *tx,
 	s16 completion_tag;
 
 	pkt = gve_alloc_pending_packet(tx);
+	if (!pkt)
+		return -ENOMEM;
+
 	pkt->skb = skb;
 	completion_tag = pkt - tx->dqo.pending_packets;
 
-- 
2.47.1

Re: [PATCH net v2] gve: add missing NULL check for gve_alloc_pending_packet() in TX DQO

[Simon Horman]

On Mon, Jun 02, 2025 at 03:34:29AM -0700, Alok Tiwari wrote:
> gve_alloc_pending_packet() can return NULL, but gve_tx_add_skb_dqo()
> did not check for this case before dereferencing the returned pointer.
> 
> Add a missing NULL check to prevent a potential NULL pointer
> dereference when allocation fails.
> 
> This improves robustness in low-memory scenarios.
> 
> Fixes: a57e5de476be ("gve: DQO: Add TX path")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> Reviewed-by: Mina Almasry <almasrymina@google.com>
> ---
> v1->v2
> added Fixes tag and [PATCH net v2]

This patch is marked as Rejected in patchwork, but it's unclear to me why.
The patch does look good to me, there was positive review to v1 which
is addressed in v2, and i see no prior comment on v2. I'm updating it's
status accordingly. Apologies if I missed something.

Reviewed-by: Simon Horman <horms@kernel.org>

-- 
pw-bot: under-review

Re: [PATCH net v2] gve: add missing NULL check for gve_alloc_pending_packet() in TX DQO

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon,  2 Jun 2025 03:34:29 -0700 you wrote:
> gve_alloc_pending_packet() can return NULL, but gve_tx_add_skb_dqo()
> did not check for this case before dereferencing the returned pointer.
> 
> Add a missing NULL check to prevent a potential NULL pointer
> dereference when allocation fails.
> 
> This improves robustness in low-memory scenarios.
> 
> [...]

Here is the summary with links:
  - [net,v2] gve: add missing NULL check for gve_alloc_pending_packet() in TX DQO
    https://git.kernel.org/netdev/net/c/12c331b29c73

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html