From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, shuah@kernel.org,
willemb@google.com, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: drv-net: tso: fix the GRE device name
Date: Wed, 4 Jun 2025 09:32:00 +0100 [thread overview]
Message-ID: <20250604083200.GC1675772@horms.kernel.org> (raw)
In-Reply-To: <20250604012031.891242-1-kuba@kernel.org>
On Tue, Jun 03, 2025 at 06:20:31PM -0700, Jakub Kicinski wrote:
> The device type for IPv4 GRE is "gre" not "ipgre",
> unlike for IPv6 which uses "ip6gre".
>
> Not sure how I missed this when writing the test, perhaps
> because all HW I have access to is on an IPv6-only network.
>
> Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-06-04 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 1:20 [PATCH net] selftests: drv-net: tso: fix the GRE device name Jakub Kicinski
2025-06-04 8:32 ` Simon Horman [this message]
2025-06-04 13:39 ` Willem de Bruijn
2025-06-05 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604083200.GC1675772@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).