From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shuah@kernel.org, willemb@google.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v2] selftests: drv-net: add configs for the TSO test
Date: Wed, 4 Jun 2025 14:53:54 -0700 [thread overview]
Message-ID: <20250604145354.4f9c33b4@kernel.org> (raw)
In-Reply-To: <68404e84d0f58_1e99f529441@willemb.c.googlers.com.notmuch>
On Wed, 04 Jun 2025 09:47:48 -0400 Willem de Bruijn wrote:
> Jakub Kicinski wrote:
> > Add missing config options for the tso.py test, specifically
> > to make sure the kernel is built with vxlan and gre tunnels.
> >
> > I noticed this while adding a TSO-capable device QEMU to the CI.
> > Previously we only run virtio tests and it doesn't report LSO
> > stats on the QEMU we have.
> >
> > Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
>
> I wonder if we'll slowly recreate tools/testing/selftests/net/config.
> An ugly hack, but maybe let the Makefile just copy that config here?
> Or append it.
Yes, even drivers/net vs drivers/net/hw is a bit annoying.
Not sure how to cleanly align with selftest infra here :(
Our CI right now only uses configs from the TARGETS we're intending
to run. While it makes sense "to a human" to include net,
is it clean to auto-include $target if drivers/$target is included?
Maybe...
To some extent I think the issue was that we haven't actually had
any device on which NIPA could run this test. Otherwise we'd have
caught the problem before merging.
next prev parent reply other threads:[~2025-06-04 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 0:16 [PATCH net v2] selftests: drv-net: add configs for the TSO test Jakub Kicinski
2025-06-04 13:47 ` Willem de Bruijn
2025-06-04 21:53 ` Jakub Kicinski [this message]
2025-06-05 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250604145354.4f9c33b4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).