From: Jakub Kicinski <kuba@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Xin Tian <tianx@yunsilicon.com>,
netdev@vger.kernel.org, leon@kernel.org, andrew+netdev@lunn.ch,
pabeni@redhat.com, edumazet@google.com, davem@davemloft.net,
jeff.johnson@oss.qualcomm.com, przemyslaw.kitszel@intel.com,
weihg@yunsilicon.com, wanry@yunsilicon.com, jacky@yunsilicon.com,
horms@kernel.org, parthiban.veerasooran@microchip.com,
masahiroy@kernel.org, kalesh-anakkur.purayil@broadcom.com,
geert+renesas@glider.be
Subject: Re: [PATCH net-next v11 14/14] xsc: add ndo_get_stats64
Date: Thu, 5 Jun 2025 06:56:15 -0700 [thread overview]
Message-ID: <20250605065615.46e015eb@kernel.org> (raw)
In-Reply-To: <CAMuHMdVMrFzeFUu+H0MvMmf82TDc=4qfM2kjcoUCXiOFLmutDA@mail.gmail.com>
On Thu, 5 Jun 2025 15:39:54 +0200 Geert Uytterhoeven wrote:
> On Thu, 5 Jun 2025 at 15:29, Jakub Kicinski <kuba@kernel.org> wrote:
> > On Thu, 5 Jun 2025 15:25:21 +0800 Xin Tian wrote:
> > > Regarding u64_stats_sync.h helpers:
> > > Since our driver exclusively runs on 64-bit platforms (ARM64 or x86_64)
> > > where u64 accesses are atomic, is it still necessary to use these helpers?
> >
> > alright.
>
> [PATCH 1/14] indeed has:
>
> depends on PCI
> depends on ARM64 || X86_64 || COMPILE_TEST
>
> However, if this device is available on a PCIe expansion card, it
> could be plugged into any system with a PCIe expansion slot?
I've been trying to fight this fight but people keep pushing back :(
Barely any new PCIe driver comes up without depending on X86_64 and/or
ARM64. Maybe we should write down in the docs that it's okay to depend
on 64b but not okay to depend on specific arches?
Requiring 32b arch support for >= 100Gbps NICs feels a bit hard to
justify to me at this stage, but I'm happy to oblige if there are
reasons.
next prev parent reply other threads:[~2025-06-05 13:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 10:40 [PATCH net-next v11 00/14] xsc: ADD Yunsilicon XSC Ethernet Driver Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 01/14] xsc: Add xsc driver basic framework Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 02/14] xsc: Enable command queue Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 03/14] xsc: Add hardware setup APIs Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 04/14] xsc: Add qp and cq management Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 05/14] xsc: Add eq and alloc Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 06/14] xsc: Init pci irq Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 07/14] xsc: Init auxiliary device Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 08/14] xsc: Add ethernet interface Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 09/14] xsc: Init net device Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 10/14] xsc: Add eth needed qp and cq apis Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 11/14] xsc: ndo_open and ndo_stop Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 12/14] xsc: Add ndo_start_xmit Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 13/14] xsc: Add eth reception data path Xin Tian
2025-04-23 10:40 ` [PATCH net-next v11 14/14] xsc: add ndo_get_stats64 Xin Tian
2025-04-25 1:48 ` Jakub Kicinski
2025-06-05 7:25 ` Xin Tian
2025-06-05 13:28 ` Jakub Kicinski
2025-06-05 13:39 ` Geert Uytterhoeven
2025-06-05 13:56 ` Jakub Kicinski [this message]
2025-06-05 14:04 ` Andrew Lunn
2025-06-05 18:49 ` Geert Uytterhoeven
2025-06-06 12:59 ` Simon Horman
2025-06-06 7:24 ` Xin Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605065615.46e015eb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms@kernel.org \
--cc=jacky@yunsilicon.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=tianx@yunsilicon.com \
--cc=wanry@yunsilicon.com \
--cc=weihg@yunsilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).