Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Wei Fang <wei.fang@nxp.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
	Clark Wang <xiaoning.wang@nxp.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"arnd@kernel.org" <arnd@kernel.org>
Subject: Re: [PATCH v2] net: enetc: fix the netc-lib driver build dependency
Date: Thu, 5 Jun 2025 15:37:04 +0300	[thread overview]
Message-ID: <20250605123704.iiavrsaz3pj4ursj@skbuf> (raw)
In-Reply-To: <PAXPR04MB85105D979659D1B8D753FC94886FA@PAXPR04MB8510.eurprd04.prod.outlook.com>

On Thu, Jun 05, 2025 at 02:05:47PM +0300, Wei Fang wrote:
> > I think you slightly misunderstood Arnd's suggestion. NXP_NTMP was named
> > "NXP_NETC_NTMP" in his proposal, and it meant "does FSL_ENETC_CORE need
> > the functionality from NXP_NETC_LIB?".
> > 
> > The switch driver shouldn't need to select NXP_NTMP. Just NXP_NETC_LIB.
> > 
> 
> For the case :NXP_ENET4=n , FSL_ENETC=y and NXP_NETC_SWITCH=m, if the
> switch driver only selects NXP_NETC_LIB, then the netc-lib driver will be compiled
> as a module. So the issue will be reported again. And Arnd also said "The switch
> module can then equally enable bool symbol."
> 
> > I don't agree with removing "NETC" from NXP_NETC_NTMP, I think it helps
> > clarify that the option pertains just to the NETC drivers.
> 
> NTMP means " NETC Table Management Protocol", I don't know why we need
> to add a 'NETC' again, it does not make sense to me.

Understood, thanks for the example. It was me who misunderstood. In that case

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

  reply	other threads:[~2025-06-05 12:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05  6:08 [PATCH v2] net: enetc: fix the netc-lib driver build dependency Wei Fang
2025-06-05  8:56 ` Vladimir Oltean
2025-06-05 11:05   ` Wei Fang
2025-06-05 12:37     ` Vladimir Oltean [this message]
2025-06-06 11:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250605123704.iiavrsaz3pj4ursj@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=arnd@kernel.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=imx@lists.linux.dev \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox