From: Vladimir Oltean <olteanv@gmail.com>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: b53: fix untagged traffic sent via cpu tagged with VID 0
Date: Thu, 5 Jun 2025 23:33:31 +0300 [thread overview]
Message-ID: <20250605203331.twof2p2orvuxwuzt@skbuf> (raw)
In-Reply-To: <20250605202043.ivkjlwtvzi6jqhqx@skbuf>
On Thu, Jun 05, 2025 at 11:20:43PM +0300, Vladimir Oltean wrote:
> Testing both on sja1105, as well as on veth using software bridging, the
> answer should be "tagged with VID 2". However, you make it sounds like
> the answer on b53 is "untagged".
Sorry, some neurons misfired. I don't expect the b53 answer to be
anything other than "tagged with VID 2". The bridge passes the skb as
tagged with VID 2 already.
Only if the bridge port VLAN 2 were egress-untagged, would the skb be
coming to ndo_start_xmit() as VLAN-untagged. Then it would be processed
in VID 2 in software, and in VID 0 in hardware. But the fact that VID 2
is egress-untagged in software just like VID 0 is egress-untagged in
hardware will mask that. That would only potentially matter for source
address learning, which I'm not sure whether it exists on CPU-injected
packets on b53.
next prev parent reply other threads:[~2025-06-05 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 19:49 [PATCH net] net: dsa: b53: fix untagged traffic sent via cpu tagged with VID 0 Jonas Gorski
2025-06-05 8:54 ` Paolo Abeni
2025-06-05 18:02 ` Florian Fainelli
2025-06-05 20:20 ` Vladimir Oltean
2025-06-05 20:33 ` Vladimir Oltean [this message]
2025-06-06 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605203331.twof2p2orvuxwuzt@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox