From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: "Maciej Żenczykowski" <maze@google.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
martin.lau@linux.dev, daniel@iogearbox.net,
john.fastabend@gmail.com, eddyz87@gmail.com, sdf@fomichev.me,
haoluo@google.com, willemb@google.com,
william.xuanziyang@huawei.com, alan.maguire@oracle.com,
bpf@vger.kernel.org
Subject: Re: [PATCH net] net: clear the dst when changing skb protocol
Date: Fri, 6 Jun 2025 10:09:04 -0700 [thread overview]
Message-ID: <20250606100904.668aa3f4@kernel.org> (raw)
In-Reply-To: <68430f86f651_266eaf294ab@willemb.c.googlers.com.notmuch>
On Fri, 06 Jun 2025 11:55:50 -0400 Willem de Bruijn wrote:
> I would drop on every program that calls bpf_skb_adjust_room() or
> bpf_skb_change_proto().
I think @maze covered it well, not all adjust_room calls matter
to L3, they may be adjusting L2. I don't feel like blanket dst
discard is either always correct or necessarily sufficient
(when rerouting the packet without adjusting length).
Let me respond to him with the draft patch..
next prev parent reply other threads:[~2025-06-06 17:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 21:06 [PATCH net] net: clear the dst when changing skb protocol Jakub Kicinski
2025-06-04 21:21 ` Maciej Żenczykowski
2025-06-05 13:22 ` Jakub Kicinski
2025-06-05 13:50 ` Maciej Żenczykowski
2025-06-05 14:01 ` Jakub Kicinski
2025-06-06 0:09 ` Willem de Bruijn
2025-06-06 0:31 ` Jakub Kicinski
2025-06-06 9:40 ` Maciej Żenczykowski
2025-06-06 17:11 ` Jakub Kicinski
2025-06-06 17:36 ` Maciej Żenczykowski
2025-06-06 15:55 ` Willem de Bruijn
2025-06-06 17:09 ` Jakub Kicinski [this message]
2025-06-04 21:45 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606100904.668aa3f4@kernel.org \
--to=kuba@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=martin.lau@linux.dev \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).