From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Paolo Abeni <pabeni@redhat.com>,
davem@davemloft.net, Andrew Lunn <andrew@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, Simon Horman <horms@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Herve Codina <herve.codina@bootlin.com>,
Romain Gantois <romain.gantois@bootlin.com>,
Jijie Shao <shaojijie@huawei.com>
Subject: Re: [PATCH net] net: phy: phy_caps: Don't skip better duplex macth on non-exact match
Date: Fri, 6 Jun 2025 11:24:11 +0200 [thread overview]
Message-ID: <20250606112411.69b1a3f9@fedora> (raw)
In-Reply-To: <aEKnQ4haQtcJWzXX@shell.armlinux.org.uk>
Hi,
On Fri, 6 Jun 2025 09:30:59 +0100
"Russell King (Oracle)" <linux@armlinux.org.uk> wrote:
> On Fri, Jun 06, 2025 at 10:19:23AM +0200, Maxime Chevallier wrote:
> > In reality, the case you're mentioning would be a device that supports
> > 1000/Full, 100/Full and 100/Half, user asks for 1000/Half, and 100/Full
> > would be reported.
> If you're version doesn't come out with a matching speed, then I'm
> afraid it's still broken.
My analysis is wrong, but the new result is right. The patch we're
discussing is correct I think, we do report a matching speed (tested on
an espressobin with manual masking of the linkmodes)
I'll update the doc though.
Maxime
prev parent reply other threads:[~2025-06-06 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 8:35 [PATCH net] net: phy: phy_caps: Don't skip better duplex macth on non-exact match Maxime Chevallier
2025-06-03 9:43 ` Jijie Shao
2025-06-03 13:10 ` Larysa Zaremba
2025-06-05 10:24 ` Paolo Abeni
2025-06-06 8:19 ` Maxime Chevallier
2025-06-06 8:30 ` Russell King (Oracle)
2025-06-06 9:24 ` Maxime Chevallier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606112411.69b1a3f9@fedora \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
--cc=shaojijie@huawei.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox