Re: [RFC net-next 4/6] eth: bnxt: support RSS on IPv6 Flow Label

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 9 Jun 2025 11:24:39 -0700 Michael Chan wrote:
> > It appears that the bnxt FW API has the relevant bit for Flow Label
> > hashing. Plumb in the support. Obey the capability bit.
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>  
> 
> Looks good to me, but we need to report RXH_IP6_FL in bnxt_grxfh() for
> IP V6 flows, right?

Ah, sorry, something like this?

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
index fd9405cadad1..4385a94d4d1e 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -1582,9 +1582,14 @@ static u64 get_ethtool_ipv4_rss(struct bnxt *bp)
 
 static u64 get_ethtool_ipv6_rss(struct bnxt *bp)
 {
+	u64 rss = 0;
+
 	if (bp->rss_hash_cfg & VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6)
-		return RXH_IP_SRC | RXH_IP_DST;
-	return 0;
+		rss |= RXH_IP_SRC | RXH_IP_DST;
+	if (bp->rss_hash_cfg & VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6_FLOW_LABEL)
+		rss |= RXH_IP6_FL;
+
+	return rss;
 }
 
 static int bnxt_grxfh(struct bnxt *bp, struct ethtool_rxnfc *cmd)

Would someone at Broadcom be able to test (per cover letter)?
I'd love to have the test validated on bnxt if possible :(
I can post a v2 with the snippet merged in if that helps.