[PATCH net-next] net: ppp: remove error variable

[PATCH net-next] net: ppp: remove error variable

[Li Jun]

the error variable did not function as a variable.
so remove it.

Signed-off-by: Li Jun <lijun01@kylinos.cn>
---
 drivers/net/ppp/pptp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
index 5feaa70b5f47..67239476781e 100644
--- a/drivers/net/ppp/pptp.c
+++ b/drivers/net/ppp/pptp.c
@@ -501,7 +501,6 @@ static int pptp_release(struct socket *sock)
 {
 	struct sock *sk = sock->sk;
 	struct pppox_sock *po;
-	int error = 0;
 
 	if (!sk)
 		return 0;
@@ -526,7 +525,7 @@ static int pptp_release(struct socket *sock)
 	release_sock(sk);
 	sock_put(sk);
 
-	return error;
+	return 0;
 }
 
 static void pptp_sock_destruct(struct sock *sk)
-- 
2.25.1

Re: [PATCH net-next] net: ppp: remove error variable

[Michal Swiatkowski]

On Mon, Jun 09, 2025 at 08:51:43AM +0800, Li Jun wrote:
> the error variable did not function as a variable.
> so remove it.
> 
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> ---
>  drivers/net/ppp/pptp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
> index 5feaa70b5f47..67239476781e 100644
> --- a/drivers/net/ppp/pptp.c
> +++ b/drivers/net/ppp/pptp.c
> @@ -501,7 +501,6 @@ static int pptp_release(struct socket *sock)
>  {
>  	struct sock *sk = sock->sk;
>  	struct pppox_sock *po;
> -	int error = 0;
>  
>  	if (!sk)
>  		return 0;
> @@ -526,7 +525,7 @@ static int pptp_release(struct socket *sock)
>  	release_sock(sk);
>  	sock_put(sk);
>  
> -	return error;
> +	return 0;
>  }
>  
>  static void pptp_sock_destruct(struct sock *sk)

Right,
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

> -- 
> 2.25.1
> 

Re: [PATCH net-next] net: ppp: remove error variable

[Subbaraya Sundeep]

On 2025-06-09 at 00:51:43, Li Jun (lijun01@kylinos.cn) wrote:
> the error variable did not function as a variable.
> so remove it.
> 
> Signed-off-by: Li Jun <lijun01@kylinos.cn>

Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com>

Thanks,
Sundeep

> ---
>  drivers/net/ppp/pptp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
> index 5feaa70b5f47..67239476781e 100644
> --- a/drivers/net/ppp/pptp.c
> +++ b/drivers/net/ppp/pptp.c
> @@ -501,7 +501,6 @@ static int pptp_release(struct socket *sock)
>  {
>  	struct sock *sk = sock->sk;
>  	struct pppox_sock *po;
> -	int error = 0;
>  
>  	if (!sk)
>  		return 0;
> @@ -526,7 +525,7 @@ static int pptp_release(struct socket *sock)
>  	release_sock(sk);
>  	sock_put(sk);
>  
> -	return error;
> +	return 0;
>  }
>  
>  static void pptp_sock_destruct(struct sock *sk)
> -- 
> 2.25.1
> 

Re: [PATCH net-next] net: ppp: remove error variable

[Jakub Kicinski]

On Mon,  9 Jun 2025 08:51:43 +0800 Li Jun wrote:
> the error variable did not function as a variable.
> so remove it.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl`` warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
-- 
pw-bot: reject