From: Jakub Kicinski <kuba@kernel.org>
To: "Maciej Żenczykowski" <maze@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
Daniel Borkmann <daniel@iogearbox.net>,
martin.lau@linux.dev, john.fastabend@gmail.com,
eddyz87@gmail.com, sdf@fomichev.me, haoluo@google.com,
willemb@google.com, william.xuanziyang@huawei.com,
alan.maguire@oracle.com, bpf@vger.kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, yonghong.song@linux.dev
Subject: Re: [PATCH net v2] net: clear the dst when changing skb protocol
Date: Mon, 9 Jun 2025 14:59:28 -0700 [thread overview]
Message-ID: <20250609145928.014a72c6@kernel.org> (raw)
In-Reply-To: <CANP3RGcUbSG3dQQbDrsYq9YSMStXbmEsq6U34jcieA_45H4_JQ@mail.gmail.com>
On Sat, 7 Jun 2025 23:33:39 +0200 Maciej Żenczykowski wrote:
> 1 meta question: as this is a fix and will thus be backported into
> 5.4+ LTS, should this be split into two patches? Either making the
> test a follow up, or even going with only the crash fix in patch 1 and
> putting the 4-in-4 and 6-in-6 behavioural change in patch 2? We'd end
> up in the same state at tip of tree... but it would affect the LTS
> backports. Honestly I'm not even sure what's best.
:) Did we go from wondering if we can strip dst unconditionally to
wondering if stripping it on encap/decap may introduce regressions?
I suppose it may be useful to split, just to make it clear which
portion of the change is the crash fix and which one is just because
we think it's more consistent.
--
pw-bot: cr
next prev parent reply other threads:[~2025-06-09 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 20:47 [PATCH net v2] net: clear the dst when changing skb protocol Jakub Kicinski
2025-06-07 21:33 ` Maciej Żenczykowski
2025-06-09 13:50 ` Willem de Bruijn
2025-06-09 22:00 ` Jakub Kicinski
2025-06-09 21:59 ` Jakub Kicinski [this message]
2025-06-09 22:02 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609145928.014a72c6@kernel.org \
--to=kuba@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=william.xuanziyang@huawei.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).