netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@gmail.com>,
	<netdev@vger.kernel.org>, Simon Horman <horms@kernel.org>,
	Nikolay Aleksandrov <razor@blackwall.org>,
	Ido Schimmel <idosch@nvidia.com>, <mlxsw@nvidia.com>
Subject: Re: [PATCH net-next 00/14] ipmr, ip6mr: Allow MC-routing locally-generated MC packets
Date: Tue, 10 Jun 2025 05:58:56 -0700	[thread overview]
Message-ID: <20250610055856.5ca1558a@kernel.org> (raw)
In-Reply-To: <cover.1749499963.git.petrm@nvidia.com>

On Mon, 9 Jun 2025 22:50:16 +0200 Petr Machata wrote:
> Multicast routing is today handled in the input path. Locally generated MC
> packets don't hit the IPMR code. Thus if a VXLAN remote address is
> multicast, the driver needs to set an OIF during route lookup. In practice
> that means that MC routing configuration needs to be kept in sync with the
> VXLAN FDB and MDB. Ideally, the VXLAN packets would be routed by the MC
> routing code instead.

I think this leads to kmemleaks:

unreferenced object 0xffff88800aabe740 (size 232):
comm "kworker/0:2", pid 471, jiffies 4295215616
hex dump (first 32 bytes):
00 40 df 08 80 88 ff ff 00 f7 5d 98 ff ff ff ff  .@........].....
a1 55 19 95 ff ff ff ff 00 00 00 00 00 00 00 00  .U..............
backtrace (crc b1fabddb):
kmem_cache_alloc_noprof (./include/linux/kmemleak.h:43 mm/slub.c:4152 mm/slub.c:4197 mm/slub.c:4204) 
dst_alloc (net/core/dst.c:89) 
ip6_rt_pcpu_alloc (net/ipv6/route.c:342 net/ipv6/route.c:1419) 
ip6_pol_route (net/ipv6/route.c:1468 net/ipv6/route.c:2305) 
fib6_rule_lookup (./include/net/ip6_fib.h:617 net/ipv6/ip6_fib.c:326) 
ip6_route_output_flags (net/ipv6/route.c:2699) 
ip6_dst_lookup_tail.constprop.0 (net/ipv6/ip6_output.c:1128) 
ip6_dst_lookup_flow (net/ipv6/ip6_output.c:1260) 
udp_tunnel6_dst_lookup (net/ipv6/ip6_udp_tunnel.c:165 net/ipv6/ip6_udp_tunnel.c:135) ip6_udp_tunnel 
vxlan_xmit_one (drivers/net/vxlan/vxlan_core.c:2540 (discriminator 4)) vxlan 
vxlan_xmit (drivers/net/vxlan/vxlan_core.c:2809) vxlan 
dev_hard_start_xmit (./include/linux/netdevice.h:5215 ./include/linux/netdevice.h:5224 net/core/dev.c:3830 net/core/dev.c:3846) 
__dev_queue_xmit (net/core/dev.h:356 net/core/dev.c:4714) 
ip6_finish_output2 (./include/net/neighbour.h:539 net/ipv6/ip6_output.c:141) 
ip6_finish_output.constprop.0 (net/ipv6/ip6_output.c:215 net/ipv6/ip6_output.c:226) 
mld_sendpack (net/ipv6/mcast.c:1872) 

hit by netdevsim udp_tunnel_nic.sh

Also, do you have a branch with the iproute2 patches we could pull 
in the CI?

  parent reply	other threads:[~2025-06-10 12:58 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 20:50 [PATCH net-next 00/14] ipmr, ip6mr: Allow MC-routing locally-generated MC packets Petr Machata
2025-06-09 20:50 ` [PATCH net-next 01/14] net: ipv4: Add a flags argument to iptunnel_xmit(), udp_tunnel_xmit_skb() Petr Machata
2025-06-12 10:28   ` Nikolay Aleksandrov
2025-06-12 11:21   ` Antonio Quartulli
2025-06-09 20:50 ` [PATCH net-next 02/14] net: ipv4: ipmr: ipmr_queue_xmit(): Drop local variable `dev' Petr Machata
2025-06-12 10:28   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 03/14] net: ipv4: ipmr: Split ipmr_queue_xmit() in two Petr Machata
2025-06-12 10:29   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 04/14] net: ipv4: Add ip_mr_output() Petr Machata
2025-06-09 20:50 ` [PATCH net-next 05/14] net: ipv6: Make udp_tunnel6_xmit_skb() void Petr Machata
2025-06-12 10:29   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 06/14] net: ipv6: Add a flags argument to ip6tunnel_xmit(), udp_tunnel6_xmit_skb() Petr Machata
2025-06-12 10:30   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 07/14] net: ipv6: ip6mr: Fix in/out netdev to pass to the FORWARD chain Petr Machata
2025-06-12 10:30   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 08/14] net: ipv6: ip6mr: Extract a helper out of ip6mr_forward2() Petr Machata
2025-06-12 10:31   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 09/14] net: ipv6: Add ip6_mr_output() Petr Machata
2025-06-12 10:35   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 10/14] vxlan: Support MC routing in the underlay Petr Machata
2025-06-12 10:36   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 11/14] selftests: forwarding: lib: Move smcrouted helpers here Petr Machata
2025-06-12 10:38   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 12/14] selftests: net: lib: Add ip_link_has_flag() Petr Machata
2025-06-12 10:38   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 13/14] selftests: forwarding: adf_mcd_start(): Allow configuring custom interfaces Petr Machata
2025-06-12 10:38   ` Nikolay Aleksandrov
2025-06-09 20:50 ` [PATCH net-next 14/14] selftests: forwarding: Add a test for verifying VXLAN MC underlay Petr Machata
2025-06-10 13:02   ` Jakub Kicinski
2025-06-10 16:22     ` Petr Machata
2025-06-10 12:58 ` Jakub Kicinski [this message]
2025-06-10 13:12   ` [PATCH net-next 00/14] ipmr, ip6mr: Allow MC-routing locally-generated MC packets Petr Machata
2025-06-11 15:30     ` Petr Machata
2025-06-11 20:23       ` Jakub Kicinski
2025-06-11 21:03         ` Kuniyuki Iwashima
2025-06-12 12:02         ` Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250610055856.5ca1558a@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=razor@blackwall.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).