netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	netdev@vger.kernel.org, Aaron Conole <aconole@redhat.com>,
	Eelco Chaudron <echaudro@redhat.com>,
	Ilya Maximets <i.maximets@ovn.org>,
	Simon Horman <horms@kernel.org>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	dev@openvswitch.org, linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH net 0/3] Revert openvswitch per-CPU storage
Date: Tue, 10 Jun 2025 09:06:29 +0200	[thread overview]
Message-ID: <20250610070629.0ShU8LLr@linutronix.de> (raw)
In-Reply-To: <63dcf1ff-7690-4300-8f76-30595c14fec1@nvidia.com>

On 2025-06-10 10:03:08 [+0300], Gal Pressman wrote:
> On 10/06/2025 9:43, Sebastian Andrzej Siewior wrote:
> > On 2025-06-10 09:26:28 [+0300], Gal Pressman wrote:
> >> This patch series reverts a set of changes that consolidated per-CPU
> >> storage structures in the openvswitch module.
> >>
> >> The original changes were intended to improve performance and reduce
> >> complexity by merging three separate per-CPU structures into one, but
> >> they have changed openvswitch to use static percpu allocations, and
> >> exhausted the reserved chunk on module init.
> >> This results in allocation of struct ovs_pcpu_storage (6488 bytes)
> >> failure on ARM.
> >>
> >> The reverts are applied in reverse order of the original commits.
> > 
> > Is the limited per-CPU storage the only problem? If so I would towards a
> > different solution rather than reverting everything.
> 
> I don't know if this is the only problem, we can't load the module
> starting with these patches.
> 
> I suggest continuing with the reverts as I assume your new solution will
> be net-next material, no?

It is a regression in -rc1 so I would try to fix this on top of -rc1
instead of reverting everything.

Sebastian

  reply	other threads:[~2025-06-10  7:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10  6:26 [PATCH net 0/3] Revert openvswitch per-CPU storage Gal Pressman
2025-06-10  6:26 ` [PATCH net 1/3] Revert "openvswitch: Move ovs_frag_data_storage into the struct ovs_pcpu_storage" Gal Pressman
2025-06-10  6:26 ` [PATCH net 2/3] Revert "openvswitch: Use nested-BH locking for ovs_pcpu_storage" Gal Pressman
2025-06-10  6:26 ` [PATCH net 3/3] Revert "openvswitch: Merge three per-CPU structures into one" Gal Pressman
2025-06-10  6:43 ` [PATCH net 0/3] Revert openvswitch per-CPU storage Sebastian Andrzej Siewior
2025-06-10  7:03   ` Gal Pressman
2025-06-10  7:06     ` Sebastian Andrzej Siewior [this message]
2025-06-10  7:08       ` Gal Pressman
2025-06-11  6:59         ` Sebastian Andrzej Siewior
2025-06-11 11:56           ` Gal Pressman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250610070629.0ShU8LLr@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=aconole@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=clrkwllms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=echaudro@redhat.com \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=kuba@kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).