From: Jakub Kicinski <kuba@kernel.org>
To: Justin Lai <justinlai0215@realtek.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <horms@kernel.org>,
<pkshih@realtek.com>, <larry.chiu@realtek.com>
Subject: Re: [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation
Date: Wed, 11 Jun 2025 14:25:23 -0700 [thread overview]
Message-ID: <20250611142523.67e7d984@kernel.org> (raw)
In-Reply-To: <20250610095518.6585-1-justinlai0215@realtek.com>
On Tue, 10 Jun 2025 17:55:18 +0800 Justin Lai wrote:
> Refine the flexibility of Rx queue allocation by using alloc_etherdev_mqs.
>
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> ---
> drivers/net/ethernet/realtek/rtase/rtase_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> index 4d37217e9a14..c22dd573418a 100644
> --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> @@ -2080,8 +2080,8 @@ static int rtase_init_board(struct pci_dev *pdev, struct net_device **dev_out,
> int ret = -ENOMEM;
>
> /* dev zeroed in alloc_etherdev */
> - dev = alloc_etherdev_mq(sizeof(struct rtase_private),
> - RTASE_FUNC_TXQ_NUM);
> + dev = alloc_etherdev_mqs(sizeof(struct rtase_private),
> + RTASE_FUNC_TXQ_NUM, RTASE_FUNC_RXQ_NUM);
> if (!dev)
> goto err_out;
>
$ git grep RTASE_FUNC_.XQ_NUM
drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_TXQ_NUM 1
drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_RXQ_NUM 1
This patch is a nop?
--
pw-bot: reject
next prev parent reply other threads:[~2025-06-11 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 9:55 [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation Justin Lai
2025-06-11 21:25 ` Jakub Kicinski [this message]
2025-06-12 7:42 ` Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611142523.67e7d984@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justinlai0215@realtek.com \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).