netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: <jiang.kun2@zte.com.cn>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>,
	<edumazet@google.com>, <pabeni@redhat.com>, <horms@kernel.org>,
	<netdev@vger.kernel.org>, <xu.xin16@zte.com.cn>,
	<yang.yang29@zte.com.cn>, <wang.yaxin@zte.com.cn>,
	<fan.yu9@zte.com.cn>, <he.peilin@zte.com.cn>,
	<tu.qiang35@zte.com.cn>, <qiu.yutan@zte.com.cn>,
	<zhang.yunkai@zte.com.cn>, <ye.xingchen@zte.com.cn>
Subject: Re: [PATCH net-next v2] net: arp: use kfree_skb_reason() in arp_rcv()
Date: Wed, 11 Jun 2025 17:17:13 -0700	[thread overview]
Message-ID: <20250611171713.1614ad32@kernel.org> (raw)
In-Reply-To: <20250610164445403aNkwCjYV-MAINIWe0T9JJ@zte.com.cn>

On Tue, 10 Jun 2025 16:44:45 +0800 (CST) jiang.kun2@zte.com.cn wrote:
>  {
>  	const struct arphdr *arp;
> +	enum skb_drop_reason drop_reason;

nit: please reorder these two lines, longer one first
-- 
pw-bot: cr

  reply	other threads:[~2025-06-12  0:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10  8:44 [PATCH net-next v2] net: arp: use kfree_skb_reason() in arp_rcv() jiang.kun2
2025-06-12  0:17 ` Jakub Kicinski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-05-27 10:57 jiang.kun2
2025-05-28  2:17 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250611171713.1614ad32@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=fan.yu9@zte.com.cn \
    --cc=he.peilin@zte.com.cn \
    --cc=horms@kernel.org \
    --cc=jiang.kun2@zte.com.cn \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=qiu.yutan@zte.com.cn \
    --cc=tu.qiang35@zte.com.cn \
    --cc=wang.yaxin@zte.com.cn \
    --cc=xu.xin16@zte.com.cn \
    --cc=yang.yang29@zte.com.cn \
    --cc=ye.xingchen@zte.com.cn \
    --cc=zhang.yunkai@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).