[PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available

[PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available

[David Thompson]

The message "Error getting PHY irq. Use polling instead"
is emitted when the mlxbf_gige driver is loaded by the
kernel before the associated gpio-mlxbf driver, and thus
the call to get the PHY IRQ fails since it is not yet
available. The driver probe() must return -EPROBE_DEFER
if acpi_dev_gpio_irq_get_by() returns the same.

Signed-off-by: David Thompson <davthompson@nvidia.com>
Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
index fb2e5b844c15..d76d7a945899 100644
--- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
+++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
@@ -447,8 +447,10 @@ static int mlxbf_gige_probe(struct platform_device *pdev)
 	priv->llu_plu_irq = platform_get_irq(pdev, MLXBF_GIGE_LLU_PLU_INTR_IDX);
 
 	phy_irq = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(&pdev->dev), "phy", 0);
-	if (phy_irq < 0) {
-		dev_err(&pdev->dev, "Error getting PHY irq. Use polling instead");
+	if (phy_irq == -EPROBE_DEFER) {
+		err = -EPROBE_DEFER;
+		goto out;
+	} else if (phy_irq < 0) {
 		phy_irq = PHY_POLL;
 	}
 
-- 
2.43.2

Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available

[Simon Horman]

On Fri, Jun 13, 2025 at 06:51:29PM +0000, David Thompson wrote:
> The message "Error getting PHY irq. Use polling instead"
> is emitted when the mlxbf_gige driver is loaded by the
> kernel before the associated gpio-mlxbf driver, and thus
> the call to get the PHY IRQ fails since it is not yet
> available. The driver probe() must return -EPROBE_DEFER
> if acpi_dev_gpio_irq_get_by() returns the same.
> 
> Signed-off-by: David Thompson <davthompson@nvidia.com>
> Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>

Thanks David,

I as a bug fix this needs a Fixes tag, which you can add
by simply replying to this email.

Else we can treat it as an enhancement for net-next.

RE: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available

[David Thompson]

> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Monday, June 16, 2025 8:45 AM
> To: David Thompson <davthompson@nvidia.com>
> Cc: andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; u.kleine-koenig@baylibre.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Asmaa Mnebhi
> <asmaa@nvidia.com>
> Subject: Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not
> available
> 
> On Fri, Jun 13, 2025 at 06:51:29PM +0000, David Thompson wrote:
> > The message "Error getting PHY irq. Use polling instead"
> > is emitted when the mlxbf_gige driver is loaded by the kernel before
> > the associated gpio-mlxbf driver, and thus the call to get the PHY IRQ
> > fails since it is not yet available. The driver probe() must return
> > -EPROBE_DEFER if acpi_dev_gpio_irq_get_by() returns the same.
> >
> > Signed-off-by: David Thompson <davthompson@nvidia.com>
> > Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>
> 
> Thanks David,
> 
> I as a bug fix this needs a Fixes tag, which you can add by simply replying to this
> email.
> 
> Else we can treat it as an enhancement for net-next.

Yes, good point Simon.

This patch is a fix, so should have the following Fixes tag:
	Fixes: 6c2a6ddca763 ("net: mellanox: mlxbf_gige: Replace non-standard interrupt handling")

Regards, Dave

Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available

[Simon Horman]

On Tue, Jun 17, 2025 at 08:07:37PM +0000, David Thompson wrote:
> > -----Original Message-----
> > From: Simon Horman <horms@kernel.org>
> > Sent: Monday, June 16, 2025 8:45 AM
> > To: David Thompson <davthompson@nvidia.com>
> > Cc: andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
> > kuba@kernel.org; pabeni@redhat.com; u.kleine-koenig@baylibre.com;
> > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Asmaa Mnebhi
> > <asmaa@nvidia.com>
> > Subject: Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not
> > available
> > 
> > On Fri, Jun 13, 2025 at 06:51:29PM +0000, David Thompson wrote:
> > > The message "Error getting PHY irq. Use polling instead"
> > > is emitted when the mlxbf_gige driver is loaded by the kernel before
> > > the associated gpio-mlxbf driver, and thus the call to get the PHY IRQ
> > > fails since it is not yet available. The driver probe() must return
> > > -EPROBE_DEFER if acpi_dev_gpio_irq_get_by() returns the same.
> > >
> > > Signed-off-by: David Thompson <davthompson@nvidia.com>
> > > Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>
> > 
> > Thanks David,
> > 
> > I as a bug fix this needs a Fixes tag, which you can add by simply replying to this
> > email.
> > 
> > Else we can treat it as an enhancement for net-next.
> 
> Yes, good point Simon.
> 
> This patch is a fix, so should have the following Fixes tag:
> 	Fixes: 6c2a6ddca763 ("net: mellanox: mlxbf_gige: Replace non-standard interrupt handling")

Thanks David,

I notice that in the meantime that this has been marked as Changes Requested
in patchwork. Presumably due to my earlier comment about a Fixes tag.

Could you post a v2 with the Fixes tag?

Feel free to also include
Reviewed-by: Simon Horman <horms@kernel.org>